From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF8FC43333 for ; Fri, 8 Jan 2021 19:34:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A47623A9D for ; Fri, 8 Jan 2021 19:34:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728960AbhAHTeh (ORCPT ); Fri, 8 Jan 2021 14:34:37 -0500 Received: from mga04.intel.com ([192.55.52.120]:18828 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728656AbhAHTeg (ORCPT ); Fri, 8 Jan 2021 14:34:36 -0500 IronPort-SDR: 0EXBG+N0nP6x/00fXdmYHLZ55leGIBNsJnk0Wk/FZl27wjxwhFuJuESzCoGUPtYOGolQVHPNrz qtzpnv9yBnpA== X-IronPort-AV: E=McAfee;i="6000,8403,9858"; a="175067803" X-IronPort-AV: E=Sophos;i="5.79,332,1602572400"; d="scan'208";a="175067803" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2021 11:33:55 -0800 IronPort-SDR: 79/KaNk1Ms8kgYGanksZ4cSW2m9LIFrAyncUUXwJFM4a65YsUwBeDQqvsYalTdouTE2tAspl2g BsrFF55Hmz7w== X-IronPort-AV: E=Sophos;i="5.79,332,1602572400"; d="scan'208";a="380227754" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.209.68.23]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2021 11:33:55 -0800 Date: Fri, 8 Jan 2021 11:33:54 -0800 From: Jesse Brandeburg To: Eric Dumazet Cc: "David S . Miller" , Jakub Kicinski , netdev , Eric Dumazet Subject: Re: [PATCH net-next 1/2] ice: drop dead code in ice_receive_skb() Message-ID: <20210108113354.00000dd9@intel.com> In-Reply-To: <20210108113903.3779510-2-eric.dumazet@gmail.com> References: <20210108113903.3779510-1-eric.dumazet@gmail.com> <20210108113903.3779510-2-eric.dumazet@gmail.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Eric Dumazet wrote: > From: Eric Dumazet > > napi_gro_receive() can never return GRO_DROP > > GRO_DROP can only be returned from napi_gro_frags() > which is the other NAPI GRO entry point. > > Followup patch will remove GRO_DROP, because drivers > are not supposed to call napi_gro_frags() if prior > napi_get_frags() has failed. > > Note that I have left the gro_dropped variable. I leave to ice > maintainers the decision to further remove it from ethtool -S results. > > Signed-off-by: Eric Dumazet > Cc: Jesse Brandeburg Acked-by: Jesse Brandeburg Jakub or David, you're welcome to apply directly as part of this series. The original code went into the kernel right as the code to remove GRO_DROP returns went in just before, but the reviews crossed each other and no-one (especially me :-( ) caught it. for reference: commit 0e00c05fa72554c86d7c7e0f538ec83bfe277c91 Merge: b18e9834f7b2 045790b7bc66 Author: David S. Miller Date: Thu Jun 25 16:16:21 2020 -0700 Subject: Merge branch 'napi_gro_receive-caller-return-value-cleanups'