From: Kalle Valo <kvalo@codeaurora.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Luca Coelho <luciano.coelho@intel.com>
Subject: Re: [1/2] iwlwifi: dbg: Don't touch the tlv data
Date: Thu, 14 Jan 2021 16:57:04 +0000 (UTC) [thread overview]
Message-ID: <20210114165704.F3E95C43461@smtp.codeaurora.org> (raw)
In-Reply-To: <20210112132449.22243-2-tiwai@suse.de>
Takashi Iwai <tiwai@suse.de> wrote:
> The commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device
> memory") added a termination of name string just to be sure, and this
> seems causing a regression, a GPF triggered at firmware loading.
> Basically we shouldn't modify the firmware data that may be provided
> as read-only.
>
> This patch drops the code that caused the regression and keep the tlv
> data as is.
>
> Fixes: ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory")
> BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1180344
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210733
> Cc: stable@vger.kernel.org
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> Acked-by: Luca Coelho <luciano.coelho@intel.com>
Patch applied to wireless-drivers.git, thanks.
a6616bc9a0af iwlwifi: dbg: Don't touch the tlv data
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210112132449.22243-2-tiwai@suse.de/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-01-14 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 13:24 [PATCH 0/2] iwlwifi: Fix a crash at loading Takashi Iwai
2021-01-12 13:24 ` [PATCH 1/2] iwlwifi: dbg: Don't touch the tlv data Takashi Iwai
2021-01-12 15:48 ` Kalle Valo
2021-01-12 16:02 ` Takashi Iwai
2021-01-12 17:08 ` Coelho, Luciano
2021-01-14 7:14 ` Kalle Valo
2021-01-14 16:57 ` Kalle Valo [this message]
2021-01-12 13:24 ` [PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const Takashi Iwai
2021-01-12 15:50 ` Kalle Valo
2021-01-12 16:05 ` Takashi Iwai
2021-01-12 17:13 ` Coelho, Luciano
2021-01-13 6:50 ` Kalle Valo
2021-02-10 11:35 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114165704.F3E95C43461@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).