* [PATCH wireless -next] rtw88: Delete useless kfree code
@ 2020-12-16 13:04 Zheng Yongjun
2020-12-17 0:55 ` Pkshih
2021-01-14 17:25 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Zheng Yongjun @ 2020-12-16 13:04 UTC (permalink / raw)
To: tony0620emma, kvalo, davem, kuba, linux-wireless, netdev,
linux-kernel
Cc: Zheng Yongjun
The parameter of kfree function is NULL, so kfree code is useless, delete it.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/net/wireless/realtek/rtw88/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
index 565efd880624..15568cd670a3 100644
--- a/drivers/net/wireless/realtek/rtw88/main.c
+++ b/drivers/net/wireless/realtek/rtw88/main.c
@@ -1249,7 +1249,6 @@ static void rtw_set_supported_band(struct ieee80211_hw *hw,
err_out:
rtw_err(rtwdev, "failed to set supported band\n");
- kfree(sband);
}
static void rtw_unset_supported_band(struct ieee80211_hw *hw,
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH wireless -next] rtw88: Delete useless kfree code
2020-12-16 13:04 [PATCH wireless -next] rtw88: Delete useless kfree code Zheng Yongjun
@ 2020-12-17 0:55 ` Pkshih
2021-01-14 17:25 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Pkshih @ 2020-12-17 0:55 UTC (permalink / raw)
To: linux-kernel@vger.kernel.org, tony0620emma@gmail.com,
zhengyongjun3@huawei.com, kvalo@codeaurora.org, kuba@kernel.org,
netdev@vger.kernel.org, davem@davemloft.net,
linux-wireless@vger.kernel.org
On Wed, 2020-12-16 at 13:04 +0000, Zheng Yongjun wrote:
> The parameter of kfree function is NULL, so kfree code is useless, delete it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtw88/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/main.c
> b/drivers/net/wireless/realtek/rtw88/main.c
> index 565efd880624..15568cd670a3 100644
> --- a/drivers/net/wireless/realtek/rtw88/main.c
> +++ b/drivers/net/wireless/realtek/rtw88/main.c
> @@ -1249,7 +1249,6 @@ static void rtw_set_supported_band(struct ieee80211_hw
> *hw,
>
> err_out:
> rtw_err(rtwdev, "failed to set supported band\n");
> - kfree(sband);
> }
>
> static void rtw_unset_supported_band(struct ieee80211_hw *hw,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH wireless -next] rtw88: Delete useless kfree code
2020-12-16 13:04 [PATCH wireless -next] rtw88: Delete useless kfree code Zheng Yongjun
2020-12-17 0:55 ` Pkshih
@ 2021-01-14 17:25 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2021-01-14 17:25 UTC (permalink / raw)
To: Zheng Yongjun
Cc: tony0620emma, davem, kuba, linux-wireless, netdev, linux-kernel,
Zheng Yongjun
Zheng Yongjun <zhengyongjun3@huawei.com> wrote:
> The parameter of kfree function is NULL, so kfree code is useless, delete it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
8873e8f56f74 rtw88: Delete useless kfree code
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201216130442.13869-1-zhengyongjun3@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-14 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-16 13:04 [PATCH wireless -next] rtw88: Delete useless kfree code Zheng Yongjun
2020-12-17 0:55 ` Pkshih
2021-01-14 17:25 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).