From: "Pali Rohár" <pali@kernel.org>
To: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>,
linux-man@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] netdevice.7: Update documentation for SIOCGIFADDR SIOCSIFADDR SIOCDIFADDR
Date: Sat, 16 Jan 2021 23:35:10 +0100 [thread overview]
Message-ID: <20210116223510.gk56aylkpo35aoev@pali> (raw)
In-Reply-To: <8e09e975-3b79-a47c-527f-84b77563d6bf@gmail.com>
On Saturday 16 January 2021 01:41:24 Alejandro Colomar (man-pages) wrote:
> On 1/12/21 8:26 PM, Pali Rohár wrote:
> > On Sunday 10 January 2021 20:57:50 Alejandro Colomar (man-pages) wrote:
> >> [ CC += netdev ]
> >>
> >> On 1/10/21 5:38 PM, Pali Rohár wrote:
> >>> On Saturday 02 January 2021 19:39:52 Pali Rohár wrote:
> >>>> Also add description for struct in6_ifreq which is used for IPv6 addresses.
> >>>>
> >>>> SIOCSIFADDR and SIOCDIFADDR can be used to add or delete IPv6 address and
> >>>> pppd is using these ioctls for a long time. Surprisingly SIOCDIFADDR cannot
> >>>> be used for deleting IPv4 address but only for IPv6 addresses.
> >>>>
> >>>> Signed-off-by: Pali Rohár <pali@kernel.org>
> >>>> ---
> >>>> man7/netdevice.7 | 50 +++++++++++++++++++++++++++++++++++++++++-------
> >>>> 1 file changed, 43 insertions(+), 7 deletions(-)
> >>>
> >>> Hello! Is something else needed for this patch?
> >>
> >> Hello Pali,
> >>
> >> Sorry, I forgot to comment a few more formatting/wording issues: see
> >> below. Apart from that, I'd prefer Michael to review this one.
> >>
> >> Thanks,
> >>
> >> Alex
> >
> > Hello Alex! I will try to explain configuring IPv4 and IPv6 addresses on
> > network interfaces, so you probably could have better way how to improve
> > description in "official" manpage. I'm not native English speaker, so I
> > would follow any suggestions from you.
> [...]
>
> Hi Pali,
>
> Thanks for explaining the process to me.
> However, I don't feel that I understand it enough to help you co-writing
> the text. I lack much background to understand your explanation. I'd
> help you with the language happily, if it was only that :)
OK! I will send a new patch version ...
> Maybe someone from netdev@ can help? Or Michael?
... and other improvements can be done later.
> Regards,
>
> Alex
>
>
> --
> Alejandro Colomar
> Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
> http://www.alejandro-colomar.es/
next prev parent reply other threads:[~2021-01-16 22:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210102140254.16714-1-pali@kernel.org>
[not found] ` <20210102183952.4155-1-pali@kernel.org>
[not found] ` <20210110163824.awdrmf3etndlyuls@pali>
2021-01-10 19:57 ` [PATCH v2] netdevice.7: Update documentation for SIOCGIFADDR SIOCSIFADDR SIOCDIFADDR Alejandro Colomar (man-pages)
2021-01-12 19:26 ` Pali Rohár
2021-01-16 0:41 ` Alejandro Colomar (man-pages)
2021-01-16 22:35 ` Pali Rohár [this message]
2021-01-16 22:36 ` [PATCH v3] " Pali Rohár
2021-01-19 20:18 ` Alejandro Colomar (man-pages)
2021-01-27 19:29 ` Pali Rohár
2021-01-28 14:05 ` Alejandro Colomar (man-pages)
2021-01-28 14:04 ` Alejandro Colomar (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210116223510.gk56aylkpo35aoev@pali \
--to=pali@kernel.org \
--cc=alx.manpages@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox