From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA3EAC433DB for ; Wed, 20 Jan 2021 08:01:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 657D52313A for ; Wed, 20 Jan 2021 08:01:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730302AbhATIAs (ORCPT ); Wed, 20 Jan 2021 03:00:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55837 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728996AbhATH7H (ORCPT ); Wed, 20 Jan 2021 02:59:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611129461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6UrxbpNYHnK4DEP6WSgA1c696nQ5LZj2MHb845FTR0o=; b=aJR6BdG5iUYXVqoTsgTrLw+cZcSn+JslUrcN8ZUypmerBU+u7Dpz3eijN9fMAWpOkJuksR yWKUCV3Ulbc2o6DS0IruLVtGVN4ovQeOVnOSGJlGvxQX10cJ449r8FB+unkDTUjm9rw2dJ ShJ8DPmazK54BDtWDy/VpeRWVTVcGXw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-JZZTvlk2MdCxWgF7xvF8ug-1; Wed, 20 Jan 2021 02:57:40 -0500 X-MC-Unique: JZZTvlk2MdCxWgF7xvF8ug-1 Received: by mail-wm1-f72.google.com with SMTP id n17so315293wmk.3 for ; Tue, 19 Jan 2021 23:57:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6UrxbpNYHnK4DEP6WSgA1c696nQ5LZj2MHb845FTR0o=; b=sQipbzbMHzEO+ju8K9/QfXUFUWCr+KNdHv1kGK2UFLQYAv41a6LRey6SU8+rzl0eXg N4ie5ghC22BhvyBGE/LkKR6rgAVzCOKChu3tpfZ2k6c9hKXioS7MwxhL7VgJPHcTRv45 j+pP791W06Knj+Y2YCXV3sI8ui7cBKDLD1nU7X0rqJY++Qb1l+DF7aoCLuKJzGmK3WGz 9xSf/qjLXJ8cnc9TJkJbo1ZsEyHZ5xeJ0KjMWtMiiHMsuIQ7ugdNSEuIAUVFDMxPJS2Z 0G+ndpXFDIJn6Bzfg6CAZ3es5DYRe858r9NvSGLlAI1/o80aZVnGqtISSTJT9fWAEIIS IvOQ== X-Gm-Message-State: AOAM5323/vrVKkvbQSLyqnPIKlBv0RfV9wIr33BlB48OBcHP/sY0Iz0R NMSZo5qvRFsTE0NPy7EiNqt7gU+itvfJwp9ae9d5rW/FUti3VDaEmCuMOPdXaRkfadA8R5zs0+g +AnGnShy0Ze1qvkAc X-Received: by 2002:a1c:a784:: with SMTP id q126mr3058501wme.52.1611129459058; Tue, 19 Jan 2021 23:57:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJwIpBmdXLlNr8vbRKHAMR3mn1UgNMPNu1agQMsKN5OdQKV4XJ/XAHPr6RwZNDY4dCN1R7xGyw== X-Received: by 2002:a1c:a784:: with SMTP id q126mr3058476wme.52.1611129458879; Tue, 19 Jan 2021 23:57:38 -0800 (PST) Received: from redhat.com (bzq-79-177-39-148.red.bezeqint.net. [79.177.39.148]) by smtp.gmail.com with ESMTPSA id k9sm2510093wma.17.2021.01.19.23.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jan 2021 23:57:38 -0800 (PST) Date: Wed, 20 Jan 2021 02:57:34 -0500 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: Alexander Lobakin , Jason Wang , "David S. Miller" , Jakub Kicinski , bjorn.topel@intel.com, Magnus Karlsson , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , virtualization@lists.linux-foundation.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 2/3] virtio-net: support IFF_TX_SKB_NO_LINEAR Message-ID: <20210120025729-mutt-send-email-mst@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 20, 2021 at 03:49:10PM +0800, Xuan Zhuo wrote: > Virtio net supports the case where the skb linear space is empty, so add > priv_flags. > > Signed-off-by: Xuan Zhuo Acked-by: Michael S. Tsirkin > --- > drivers/net/virtio_net.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index ba8e637..f2ff6c3 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -2972,7 +2972,8 @@ static int virtnet_probe(struct virtio_device *vdev) > return -ENOMEM; > > /* Set up network device as normal. */ > - dev->priv_flags |= IFF_UNICAST_FLT | IFF_LIVE_ADDR_CHANGE; > + dev->priv_flags |= IFF_UNICAST_FLT | IFF_LIVE_ADDR_CHANGE | > + IFF_TX_SKB_NO_LINEAR; > dev->netdev_ops = &virtnet_netdev; > dev->features = NETIF_F_HIGHDMA; > > -- > 1.8.3.1