From: Jason Gunthorpe <jgg@nvidia.com>
To: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
Cc: Saeed Mahameed <saeed@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <alexander.duyck@gmail.com>,
<edwin.peer@broadcom.com>, <dsahern@kernel.org>,
<kiran.patil@intel.com>, <jacob.e.keller@intel.com>,
<david.m.ertman@intel.com>, <dan.j.williams@intel.com>,
Parav Pandit <parav@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [net-next V9 14/14] net/mlx5: Add devlink subfunction port documentation
Date: Thu, 21 Jan 2021 20:11:57 -0400 [thread overview]
Message-ID: <20210122001157.GE4147@nvidia.com> (raw)
In-Reply-To: <d5ef3359-ff3c-0e71-8312-0f24c3af4bce@intel.com>
On Thu, Jan 21, 2021 at 12:59:55PM -0800, Samudrala, Sridhar wrote:
> > + mlx5_core.sf.4
> > + (subfunction auxiliary device)
> > + /\
> > + / \
> > + / \
> > + / \
> > + / \
> > + mlx5_core.eth.4 mlx5_core.rdma.4
> > + (sf eth aux dev) (sf rdma aux dev)
> > + | |
> > + | |
> > + p0sf88 mlx5_0
> > + (sf netdev) (sf rdma device)
>
> This picture seems to indicate that when SF is activated, a sub
> function auxiliary device is created
Yes
> and when a driver is bound to that sub function aux device and
> probed, 2 additional auxiliary devices are created.
More than two, but yes
> Is this correct? Are all these auxiliary devices seen on the same
> aux bus?
Yes
> Why do we need another sf eth aux device?
The first aux device represents the physical HW and mlx5_core binds to it,
the analog is like a pci_device.
The other aux devices represent the subsystem split of the mlx5 driver
- mlx5_core creates them and each subsystem in turn binds to the
mlx5_core driver. This already exists, and Intel will be doing this as
well whenever the RDMA driver is posted again..
Jason
next prev parent reply other threads:[~2021-01-22 0:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 8:52 [pull request][net-next V9 00/14] Add mlx5 subfunction support Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 01/14] devlink: Prepare code to fill multiple port function attributes Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 02/14] devlink: Introduce PCI SF port flavour and port attribute Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 03/14] devlink: Support add and delete devlink port Saeed Mahameed
2021-01-21 20:50 ` Samudrala, Sridhar
2021-01-22 3:31 ` Parav Pandit
2021-01-22 21:23 ` Jacob Keller
2021-01-21 8:52 ` [net-next V9 04/14] devlink: Support get and set state of port function Saeed Mahameed
2021-01-21 20:52 ` Samudrala, Sridhar
2021-01-22 3:34 ` Parav Pandit
2021-01-21 8:52 ` [net-next V9 05/14] net/mlx5: Introduce vhca state event notifier Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 06/14] net/mlx5: SF, Add auxiliary device support Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 07/14] net/mlx5: SF, Add auxiliary device driver Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 08/14] net/mlx5: E-switch, Prepare eswitch to handle SF vport Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 09/14] net/mlx5: E-switch, Add eswitch helpers for " Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 10/14] net/mlx5: SF, Add port add delete functionality Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 11/14] net/mlx5: SF, Port function state change support Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 12/14] devlink: Add devlink port documentation Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 13/14] devlink: Extend devlink port documentation for subfunctions Saeed Mahameed
2021-01-21 8:52 ` [net-next V9 14/14] net/mlx5: Add devlink subfunction port documentation Saeed Mahameed
2021-01-21 20:59 ` Samudrala, Sridhar
2021-01-22 0:11 ` Jason Gunthorpe [this message]
2021-01-23 20:09 ` Samudrala, Sridhar
2021-01-25 13:06 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122001157.GE4147@nvidia.com \
--to=jgg@nvidia.com \
--cc=alexander.duyck@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=dsahern@kernel.org \
--cc=edwin.peer@broadcom.com \
--cc=jacob.e.keller@intel.com \
--cc=kiran.patil@intel.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).