From: Ido Schimmel <idosch@idosch.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"jiri@nvidia.com" <jiri@nvidia.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP
Date: Sun, 24 Jan 2021 10:45:14 +0200 [thread overview]
Message-ID: <20210124084514.GB2819717@shredder.lan> (raw)
In-Reply-To: <20210123121439.4290b002@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Sat, Jan 23, 2021 at 12:14:39PM -0800, Jakub Kicinski wrote:
> On Sat, 23 Jan 2021 18:03:48 +0200 Ido Schimmel wrote:
> > [DEVLINK_ATTR_STATS_RX_DROPPED]
>
> nit: maybe discarded? dropped sounds like may have been due to an
> overflow or something
Well, it's an existing attribute which is why I suggested using it.
next prev parent reply other threads:[~2021-01-24 8:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 8:36 [PATCH net-next] net: core: devlink: add new trap action HARD_DROP Oleksandr Mazur
2021-01-23 1:12 ` Jakub Kicinski
2021-01-23 16:03 ` Ido Schimmel
2021-01-23 20:14 ` Jakub Kicinski
2021-01-24 8:45 ` Ido Schimmel [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-21 11:29 Oleksandr Mazur
2021-01-21 12:21 ` Ido Schimmel
2021-01-21 17:36 ` Jakub Kicinski
2021-01-25 12:12 ` Jiri Pirko
2021-01-25 12:24 ` Oleksandr Mazur
2021-01-25 14:56 ` Jiri Pirko
2021-01-25 17:40 ` Ido Schimmel
2021-01-22 8:30 ` Oleksandr Mazur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124084514.GB2819717@shredder.lan \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oleksandr.mazur@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).