netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Edwin Peer <edwin.peer@broadcom.com>
To: netdev@vger.kernel.org
Cc: Edwin Peer <edwin.peer@broadcom.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Andrew Gospodarek <andrew.gospodarek@broadcom.com>,
	Michael Chan <michael.chan@broadcom.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Michal Kubecek <mkubecek@suse.cz>,
	David Ahern <dsahern@gmail.com>
Subject: [PATCH net-next v2 0/1] support more VFs in RTM_GETLINK
Date: Tue, 26 Jan 2021 09:40:23 -0800	[thread overview]
Message-ID: <20210126174024.185001-1-edwin.peer@broadcom.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 978 bytes --]

RTM_GETLINK for greater than about 220 VFs truncates IFLA_VFINFO_LIST
due to the maximum reach of nlattr's nla_len being exceeded. There is
not a lot of enthusiasm for extensive fixes to the deprecated netlink
ABI for VF config, but there appears to be even less appetite for the
kinds of work arounds that would be necessitated in order to truly
keep it frozen [1].

Any kind of fix for this at the RTM_GETLINK VF API layer is also a no
go [2]. For now, lets fix the bits that are uncontroversial so that a
naked 'ip link show' (without stats) works.

v2: Drop the pieces that require further discussion.

[1] https://lore.kernel.org/netdev/20210115225950.18762-1-edwin.peer@broadcom.com/
[2] https://marc.info/?l=linux-netdev&m=161163943811663 (missing on lore)

Edwin Peer (1):
  rtnetlink: extend RTEXT_FILTER_SKIP_STATS to IFLA_VF_INFO

 net/core/rtnetlink.c | 96 +++++++++++++++++++++++---------------------
 1 file changed, 51 insertions(+), 45 deletions(-)

-- 
2.30.0


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4160 bytes --]

             reply	other threads:[~2021-01-26 23:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 17:40 Edwin Peer [this message]
2021-01-26 17:40 ` [PATCH net-next v2 1/1] rtnetlink: extend RTEXT_FILTER_SKIP_STATS to IFLA_VF_INFO Edwin Peer
2021-01-26 20:36   ` Jakub Kicinski
2021-01-26 22:42     ` Edwin Peer
2021-01-28  3:50   ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210126174024.185001-1-edwin.peer@broadcom.com \
    --to=edwin.peer@broadcom.com \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=dsahern@gmail.com \
    --cc=kuba@kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).