From: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
To: <kuniyu@amazon.co.jp>
Cc: <aams@amazon.de>, <borisp@mellanox.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <kuni1840@gmail.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<tariqt@mellanox.com>
Subject: RE: [PATCH net] net: Remove redundant calls of sk_tx_queue_clear().
Date: Wed, 27 Jan 2021 22:29:54 +0900 [thread overview]
Message-ID: <20210127132954.13465-1-kuniyu@amazon.co.jp> (raw)
In-Reply-To: <20210127125018.7059-1-kuniyu@amazon.co.jp>
From: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
Date: Wed, 27 Jan 2021 21:50:18 +0900
> The commit 41b14fb8724d ("net: Do not clear the sock TX queue in
> sk_set_socket()") removes sk_tx_queue_clear() from sk_set_socket() and adds
> it instead in sk_alloc() and sk_clone_lock() to fix an issue introduced in
> the commit e022f0b4a03f ("net: Introduce sk_tx_queue_mapping"). However,
> the original commit had already put sk_tx_queue_clear() in sk_prot_alloc():
> the callee of sk_alloc() and sk_clone_lock(). Thus sk_tx_queue_clear() is
> called twice in each path currently.
>
> This patch removes the redundant calls of sk_tx_queue_clear() in sk_alloc()
> and sk_clone_lock().
>
> Fixes: 41b14fb8724d ("net: Do not clear the sock TX queue in sk_set_socket()")
> CC: Tariq Toukan <tariqt@mellanox.com>
> CC: Boris Pismenny <borisp@mellanox.com>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
> Reviewed-by: Amit Shah <aams@amazon.de>
I'm sorry, I have respun the v2 patch.
So, please ignore v1.
v2: https://lore.kernel.org/netdev/20210127132215.10842-1-kuniyu@amazon.co.jp/
Best regards,
Kuniyuki
next prev parent reply other threads:[~2021-01-27 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 12:50 [PATCH net] net: Remove redundant calls of sk_tx_queue_clear() Kuniyuki Iwashima
2021-01-27 13:29 ` Kuniyuki Iwashima [this message]
2021-01-27 14:54 ` Eric Dumazet
2021-01-27 16:52 ` Kuniyuki Iwashima
2021-01-27 17:05 ` Eric Dumazet
2021-01-27 17:31 ` Kuniyuki Iwashima
2021-01-27 17:34 ` Eric Dumazet
2021-01-27 17:56 ` Kuniyuki Iwashima
2021-01-27 18:07 ` Eric Dumazet
2021-01-27 18:20 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127132954.13465-1-kuniyu@amazon.co.jp \
--to=kuniyu@amazon.co.jp \
--cc=aams@amazon.de \
--cc=borisp@mellanox.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox