From: Vladimir Oltean <olteanv@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH net-next 2/4] net: dsa: automatically bring user ports down when master goes down
Date: Thu, 28 Jan 2021 02:50:14 +0200 [thread overview]
Message-ID: <20210128005014.z6bteom6qkmopzf4@skbuf> (raw)
In-Reply-To: <YBIJZuy6iXeNQpxm@lunn.ch>
On Thu, Jan 28, 2021 at 01:46:30AM +0100, Andrew Lunn wrote:
> > + case NETDEV_GOING_DOWN: {
> > + struct dsa_port *dp, *cpu_dp;
> > + struct dsa_switch_tree *dst;
> > + int err = 0;
> > +
> > + if (!netdev_uses_dsa(dev))
> > + return NOTIFY_DONE;
> > +
> > + cpu_dp = dev->dsa_ptr;
> > + dst = cpu_dp->ds->dst;
> > +
> > + list_for_each_entry(dp, &dst->ports, list) {
> > + if (!dsa_is_user_port(dp->ds, dp->index)) {
>
> !dsa_is_user_port() ??
>
> That ! seems odd.
Oops, that's something that I refactored at the last minute after I
prototyped the idea from:
if (!dsa_is_user_port(dp->ds, dp->index))
continue;
because it looked uglier that way.
next prev parent reply other threads:[~2021-01-28 0:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 1:00 [PATCH net-next 0/4] Automatically manage DSA master interface state Vladimir Oltean
2021-01-27 1:00 ` [PATCH net-next 1/4] net: dsa: automatically bring up DSA master when opening user port Vladimir Oltean
2021-01-28 0:51 ` Andrew Lunn
2021-01-28 1:41 ` Florian Fainelli
2021-01-27 1:00 ` [PATCH net-next 2/4] net: dsa: automatically bring user ports down when master goes down Vladimir Oltean
2021-01-28 0:46 ` Andrew Lunn
2021-01-28 0:50 ` Vladimir Oltean [this message]
2021-01-28 0:52 ` Andrew Lunn
2021-01-28 1:43 ` Florian Fainelli
2021-01-27 1:00 ` [PATCH net-next 3/4] Revert "net: Have netpoll bring-up DSA management interface" Vladimir Oltean
2021-01-28 0:52 ` Andrew Lunn
2021-01-28 1:43 ` Florian Fainelli
2021-01-27 1:00 ` [PATCH net-next 4/4] Revert "net: ipv4: handle DSA enabled master network devices" Vladimir Oltean
2021-01-28 0:56 ` Andrew Lunn
2021-01-28 1:43 ` Florian Fainelli
2021-01-27 1:25 ` [PATCH net-next 0/4] Automatically manage DSA master interface state Vladimir Oltean
2021-01-27 12:03 ` Vladimir Oltean
2021-01-28 1:03 ` Florian Fainelli
2021-01-28 1:30 ` Vladimir Oltean
2021-01-28 1:55 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128005014.z6bteom6qkmopzf4@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).