From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56689C433DB for ; Thu, 28 Jan 2021 07:36:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 143506146D for ; Thu, 28 Jan 2021 07:36:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232138AbhA1Hgb (ORCPT ); Thu, 28 Jan 2021 02:36:31 -0500 Received: from m42-8.mailgun.net ([69.72.42.8]:49638 "EHLO m42-8.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232096AbhA1HeT (ORCPT ); Thu, 28 Jan 2021 02:34:19 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1611819240; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=9W6Vf1R++yjjF3FxF3cPAfaLSdNa8uzt5rRAyBg4yjw=; b=G/L7+Nr4GLztBxkccbwdKLeQyMzc1M/sSVX0A4M4UNan6+SOJWGYwgBoe51vwSfOo8WQZscY YRicuSi8iJGfvl5/tS9QM162je4BTqtx8B2GaCYhaiK+O+xfvpJdFgRGIRZxRTNu9WOgYNbL 2ylznz32A7nrVmtXAyUwNl/WwK8= X-Mailgun-Sending-Ip: 69.72.42.8 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 601268c1beacd1a252aa8e91 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 28 Jan 2021 07:33:21 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 35C1BC433ED; Thu, 28 Jan 2021 07:33:21 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id BE25CC433C6; Thu, 28 Jan 2021 07:33:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BE25CC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath9k: Add separate entry for LED triggers to fix module builds From: Kalle Valo In-Reply-To: <20201227143034.1134829-1-krzk@kernel.org> References: <20201227143034.1134829-1-krzk@kernel.org> To: Krzysztof Kozlowski Cc: QCA ath9k Development , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , kernel test robot User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210128073321.35C1BC433ED@smtp.codeaurora.org> Date: Thu, 28 Jan 2021 07:33:21 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Krzysztof Kozlowski wrote: > After commit 72cdab808714 ("ath9k: Do not select MAC80211_LEDS by > default") a configuration like: > - MAC80211_LEDS=y > - LEDS_CLASS=m > - NEW_LEDS=y > - ATH9K=y > leads to a build failure: > > /usr/bin/ld: drivers/net/wireless/ath/ath9k/gpio.o: in function `ath_deinit_leds': > drivers/net/wireless/ath/ath9k/gpio.c:69: undefined reference to `led_classdev_unregister' > /usr/bin/ld: drivers/net/wireless/ath/ath9k/gpio.o: in function `led_classdev_register': > include/linux/leds.h:190: undefined reference to `led_classdev_register_ext' > > To be able to use LED triggers, the LEDS_CLASS can only be a module > if ath9k driver is a module as well. > > Reported-by: kernel test robot > Fixes: 72cdab808714 ("ath9k: Do not select MAC80211_LEDS by default") > Signed-off-by: Krzysztof Kozlowski I took Arnd's patch instead: https://patchwork.kernel.org/project/linux-wireless/patch/20210125113654.2408057-1-arnd@kernel.org/ But I think we really need the cleanup Arnd proposes during the discussion so that we have consistent LED handling in wireless drivers. Patches very welcome. Patch set to Superseded. -- https://patchwork.kernel.org/project/linux-wireless/patch/20201227143034.1134829-1-krzk@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches