From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: Kevin Lo <kevlo@kevlo.org>,
netdev@vger.kernel.org, sassmann@redhat.com,
anthony.l.nguyen@intel.com, Sasha Neftin <sasha.neftin@intel.com>
Subject: [PATCH net 3/4] igc: check return value of ret_val in igc_config_fc_after_link_up
Date: Thu, 28 Jan 2021 13:38:50 -0800 [thread overview]
Message-ID: <20210128213851.2499012-4-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20210128213851.2499012-1-anthony.l.nguyen@intel.com>
From: Kevin Lo <kevlo@kevlo.org>
Check return value from ret_val to make error check actually work.
Fixes: 4eb8080143a9 ("igc: Add setup link functionality")
Signed-off-by: Kevin Lo <kevlo@kevlo.org>
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/igc/igc_mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c
index 09cd0ec7ee87..67b8ffd21d8a 100644
--- a/drivers/net/ethernet/intel/igc/igc_mac.c
+++ b/drivers/net/ethernet/intel/igc/igc_mac.c
@@ -638,7 +638,7 @@ s32 igc_config_fc_after_link_up(struct igc_hw *hw)
}
out:
- return 0;
+ return ret_val;
}
/**
--
2.26.2
next prev parent reply other threads:[~2021-01-28 21:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 21:38 [PATCH net 0/4][pull request] Intel Wired LAN Driver Updates 2021-01-28 Tony Nguyen
2021-01-28 21:38 ` [PATCH net 1/4] igc: Report speed and duplex as unknown when device is runtime suspended Tony Nguyen
2021-01-30 6:22 ` Jakub Kicinski
2021-01-30 14:00 ` Neftin, Sasha
2021-01-30 18:12 ` Jakub Kicinski
2021-01-31 10:22 ` Neftin, Sasha
2021-02-01 22:04 ` Jakub Kicinski
2021-01-28 21:38 ` [PATCH net 2/4] igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr Tony Nguyen
2021-01-28 21:38 ` Tony Nguyen [this message]
2021-01-28 21:38 ` [PATCH net 4/4] i40e: Revert "i40e: don't report link up for a VF who hasn't enabled queues" Tony Nguyen
2021-01-29 20:23 ` Willem de Bruijn
2021-01-30 0:09 ` Jacob Keller
2021-01-30 2:00 ` Willem de Bruijn
2021-01-30 6:18 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128213851.2499012-4-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=kevlo@kevlo.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sasha.neftin@intel.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).