Re: [PATCH net-next v3 1/8] ethtool: Add support for configuring frame preemption

Vinicius Costa Gomes
2021-03-05T22:39:16Z

Vladimir Oltean <olteanv@gmail.com> writes:

> On Tue, Mar 02, 2021 at 04:40:55PM -0800, Vinicius Costa Gomes wrote:
>> Hi Vladimir,
>>
>> Vladimir Oltean <olteanv@gmail.com> writes:
>>
>> > Hi Vinicius,
>> >
>> > On Fri, Jan 22, 2021 at 02:44:46PM -0800, Vinicius Costa Gomes wrote:
>> >> Frame preemption (described in IEEE 802.3br-2016) defines the concept
>> >> of preemptible and express queues. It allows traffic from express
>> >> queues to "interrupt" traffic from preemptible queues, which are
>> >> "resumed" after the express traffic has finished transmitting.
>> >>
>> >> Frame preemption can only be used when both the local device and the
>> >> link partner support it.
>> >>
>> >> Only parameters for enabling/disabling frame preemption and
>> >> configuring the minimum fragment size are included here. Expressing
>> >> which queues are marked as preemptible is left to mqprio/taprio, as
>> >> having that information there should be easier on the user.
>> >>
>> >> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>> >> ---
>> >
>> > I just noticed that the aMACMergeStatusVerify variable is not exposed in
>> > the PREEMPT_GET command, which would allow the user to inspect the state
>> > of the MAC merge sublayer verification state machine. Also, a way in the
>> > PREEMPT_SET command to set the disableVerify variable would be nice.
>> >
>>
>> The hardware I have won't have support for this.
>
> What exactly is not supported, FP verification or the disabling of it?
> Does your hardware at least respond to verification frames?
>

Not supported in the sense that the NIC doesn't expose those variables
into registers.

About the behavior, I am asking our hardware folks.

Cheers,
--
Vinicius