From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B9DC433E0 for ; Mon, 1 Feb 2021 18:09:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55BFD64DDE for ; Mon, 1 Feb 2021 18:09:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231175AbhBASJs (ORCPT ); Mon, 1 Feb 2021 13:09:48 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44335 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbhBASJr (ORCPT ); Mon, 1 Feb 2021 13:09:47 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 381A65C0117; Mon, 1 Feb 2021 13:08:41 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 01 Feb 2021 13:08:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=P6V5zw hvdkgX9CEKWr1Xik4kt8vW8ILtjmdEVAHYkUQ=; b=pxkhNCScKxGySo3SwjMXpX FTWsPQQyXOq1ebSv4ebUl6Ei6GzQgdHoogcTrzz1WNnIjEJAdRKW0WcFgRKzIbOT sbIx9ANYqjAnaDS4qIxVFlol8q/W14kQROXs/cj0Hcua0hrHEDFr6xRUDVNcOca1 1lNXjnWRB/02gmzevJxKJDnWs0gUsZaMZDD6lK110tShEdQSOD+QKBDlgItEFEgT 16wSaSo6+hvHQ0xv7i4+xM0FD+Xte/YuzNp7j6Gp2EmQHV5QflgZNdqzCpyVuzsQ YzB5IZkVyyKuWV4G7Wc8/pNtL33xBcrweKwGoudRf0XTwq0EWb4m0c8SlGesuNHw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeekgddutdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedtffekkeefudffveegueejffejhfetgfeuuefgvedtieehudeuueekhfduheel teenucfkphepkeegrddvvdelrdduheefrdeggeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: from localhost (igld-84-229-153-44.inter.net.il [84.229.153.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 745BC24005E; Mon, 1 Feb 2021 13:08:40 -0500 (EST) Date: Mon, 1 Feb 2021 20:08:37 +0200 From: Ido Schimmel To: Chris Mi Cc: Jakub Kicinski , Cong Wang , Linux Kernel Network Developers , jiri@nvidia.com, Saeed Mahameed , kernel test robot Subject: Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency Message-ID: <20210201180837.GB3456040@shredder.lan> References: <20210128014543.521151-1-cmi@nvidia.com> <6c586e9a-b672-6e60-613b-4fb6e6db8c9a@nvidia.com> <20210129123009.3c07563d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210130144231.GA3329243@shredder.lan> <8924ef5a-a3ac-1664-ca11-5f2a1f35399a@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8924ef5a-a3ac-1664-ca11-5f2a1f35399a@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 01, 2021 at 09:37:11AM +0800, Chris Mi wrote: > Hi Ido, > > On 1/30/2021 10:42 PM, Ido Schimmel wrote: > > On Fri, Jan 29, 2021 at 12:30:09PM -0800, Jakub Kicinski wrote: > > > On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote: > > > > Instead of discussing it several days, maybe it's better to review > > > > current patch, so that we can move forward :) > > > It took you 4 revisions to post a patch which builds cleanly and now > > > you want to hasten the review? My favorite kind of submission. > > > > > > The mlxsw core + spectrum drivers are 65 times the size of psample > > > on my system. Why is the dependency a problem? > > mlxsw has been using psample for ~4 years and I don't remember seeing a > > single complaint about the dependency. I don't understand why this patch > > is needed. > Please see Saeed's comment in previous email: > > " > > The issue is with distros who ship modules independently.. having a > hard dependency will make it impossible for basic mlx5_core.ko users to > load the driver when psample is not installed/loaded. > > I prefer to have 0 dependency on external modules in a HW driver. > " I saw it, but it basically comes down to personal preferences. > > We are working on a tc sample offload feature for mlx5_core. The distros > are likely to request us to do this. So we address it before submitting > the driver changes. Which distros? Can they comment here? mlxsw is in RHEL and I don't remember queries from them about the psample module. > > Regards, > Chris >