From: kernel test robot <lkp@intel.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>, bpf@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Jesper Dangaard Brouer <brouer@redhat.com>,
netdev@vger.kernel.org, Daniel Borkmann <borkmann@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
maze@google.com, lmb@cloudflare.com, shaun@tigera.io,
Lorenzo Bianconi <lorenzo@kernel.org>,
marek@cloudflare.com
Subject: Re: [PATCH bpf-next V14 5/7] bpf: drop MTU check when doing TC-BPF redirect to ingress
Date: Tue, 2 Feb 2021 03:58:26 +0800 [thread overview]
Message-ID: <202102020336.TLMjIpyW-lkp@intel.com> (raw)
In-Reply-To: <161217675170.494501.11194096254681150724.stgit@firesoul>
[-- Attachment #1: Type: text/plain, Size: 2749 bytes --]
Hi Jesper,
I love your patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/bpf-New-approach-for-BPF-MTU-handling/20210201-185654
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-randconfig-r014-20210201 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 275c6af7d7f1ed63a03d05b4484413e447133269)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/8d1404896e0346004412f5ffd64ef92ac578e5de
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jesper-Dangaard-Brouer/bpf-New-approach-for-BPF-MTU-handling/20210201-185654
git checkout 8d1404896e0346004412f5ffd64ef92ac578e5de
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/core/dev.c:2201:5: warning: no previous prototype for function '__dev_forward_skb2' [-Wmissing-prototypes]
int __dev_forward_skb2(struct net_device *dev, struct sk_buff *skb,
^
net/core/dev.c:2201:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int __dev_forward_skb2(struct net_device *dev, struct sk_buff *skb,
^
static
net/core/dev.c:4937:1: warning: unused function 'sch_handle_ingress' [-Wunused-function]
sch_handle_ingress(struct sk_buff *skb, struct packet_type **pt_prev, int *ret,
^
net/core/dev.c:5086:19: warning: unused function 'nf_ingress' [-Wunused-function]
static inline int nf_ingress(struct sk_buff *skb, struct packet_type **pt_prev,
^
3 warnings generated.
vim +/__dev_forward_skb2 +2201 net/core/dev.c
2200
> 2201 int __dev_forward_skb2(struct net_device *dev, struct sk_buff *skb,
2202 bool check_mtu)
2203 {
2204 int ret = ____dev_forward_skb(dev, skb, check_mtu);
2205
2206 if (likely(!ret)) {
2207 skb->protocol = eth_type_trans(skb, dev);
2208 skb_postpull_rcsum(skb, eth_hdr(skb), ETH_HLEN);
2209 }
2210
2211 return ret;
2212 }
2213
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32364 bytes --]
next prev parent reply other threads:[~2021-02-01 20:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 10:52 [PATCH bpf-next V14 0/7] bpf: New approach for BPF MTU handling Jesper Dangaard Brouer
2021-02-01 10:52 ` [PATCH bpf-next V14 1/7] bpf: Remove MTU check in __bpf_skb_max_len Jesper Dangaard Brouer
2021-02-01 10:52 ` [PATCH bpf-next V14 2/7] bpf: fix bpf_fib_lookup helper MTU check for SKB ctx Jesper Dangaard Brouer
2021-02-01 10:52 ` [PATCH bpf-next V14 3/7] bpf: bpf_fib_lookup return MTU value as output when looked up Jesper Dangaard Brouer
2021-02-01 10:52 ` [PATCH bpf-next V14 4/7] bpf: add BPF-helper for MTU checking Jesper Dangaard Brouer
2021-02-01 10:52 ` [PATCH bpf-next V14 5/7] bpf: drop MTU check when doing TC-BPF redirect to ingress Jesper Dangaard Brouer
2021-02-01 19:58 ` kernel test robot [this message]
2021-02-01 10:52 ` [PATCH bpf-next V14 6/7] selftests/bpf: use bpf_check_mtu in selftest test_cls_redirect Jesper Dangaard Brouer
2021-02-01 10:52 ` [PATCH bpf-next V14 7/7] selftests/bpf: tests using bpf_check_mtu BPF-helper Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102020336.TLMjIpyW-lkp@intel.com \
--to=lkp@intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=clang-built-linux@googlegroups.com \
--cc=kbuild-all@lists.01.org \
--cc=lmb@cloudflare.com \
--cc=lorenzo@kernel.org \
--cc=marek@cloudflare.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=shaun@tigera.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox