* [PATCH v1] net: hsr: align sup_multicast_addr in struct hsr_priv to u16 boundary
@ 2021-02-02 9:03 Andreas Oetken
2021-02-02 17:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Oetken @ 2021-02-02 9:03 UTC (permalink / raw)
To: David S . Miller, netdev; +Cc: Andreas Oetken, Andreas Oetken
From: Andreas Oetken <andreas.oetken@siemens.com>
sup_multicast_addr is passed to ether_addr_equal for address comparison
which casts the address inputs to u16 leading to an unaligned access.
Aligning the sup_multicast_addr to u16 boundary fixes the issue.
Signed-off-by: Andreas Oetken <andreas.oetken@siemens.com>
---
net/hsr/hsr_main.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/hsr/hsr_main.h b/net/hsr/hsr_main.h
index 7dc92ce5a134..a9c30a608e35 100644
--- a/net/hsr/hsr_main.h
+++ b/net/hsr/hsr_main.h
@@ -217,7 +217,10 @@ struct hsr_priv {
u8 net_id; /* for PRP, it occupies most significant 3 bits
* of lan_id
*/
- unsigned char sup_multicast_addr[ETH_ALEN];
+ unsigned char sup_multicast_addr[ETH_ALEN] __aligned(sizeof(u16));
+ /* Align to u16 boundary to avoid unaligned access
+ * in ether_addr_equal
+ */
#ifdef CONFIG_DEBUG_FS
struct dentry *node_tbl_root;
#endif
--
2.30.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v1] net: hsr: align sup_multicast_addr in struct hsr_priv to u16 boundary
@ 2021-02-02 9:13 Andreas Oetken
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Oetken @ 2021-02-02 9:13 UTC (permalink / raw)
To: David S . Miller, netdev; +Cc: Andreas Oetken, Andreas Oetken
From: Andreas Oetken <andreas.oetken@siemens.com>
sup_multicast_addr is passed to ether_addr_equal for address comparison
which casts the address inputs to u16 leading to an unaligned access.
Aligning the sup_multicast_addr to u16 boundary fixes the issue.
Signed-off-by: Andreas Oetken <andreas.oetken@siemens.com>
---
net/hsr/hsr_main.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/hsr/hsr_main.h b/net/hsr/hsr_main.h
index 7dc92ce5a134..a9c30a608e35 100644
--- a/net/hsr/hsr_main.h
+++ b/net/hsr/hsr_main.h
@@ -217,7 +217,10 @@ struct hsr_priv {
u8 net_id; /* for PRP, it occupies most significant 3 bits
* of lan_id
*/
- unsigned char sup_multicast_addr[ETH_ALEN];
+ unsigned char sup_multicast_addr[ETH_ALEN] __aligned(sizeof(u16));
+ /* Align to u16 boundary to avoid unaligned access
+ * in ether_addr_equal
+ */
#ifdef CONFIG_DEBUG_FS
struct dentry *node_tbl_root;
#endif
--
2.30.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] net: hsr: align sup_multicast_addr in struct hsr_priv to u16 boundary
2021-02-02 9:03 [PATCH v1] net: hsr: align sup_multicast_addr in struct hsr_priv to u16 boundary Andreas Oetken
@ 2021-02-02 17:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-02-02 17:00 UTC (permalink / raw)
To: Andreas Oetken; +Cc: davem, netdev, andreas.oetken
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 2 Feb 2021 10:03:04 +0100 you wrote:
> From: Andreas Oetken <andreas.oetken@siemens.com>
>
> sup_multicast_addr is passed to ether_addr_equal for address comparison
> which casts the address inputs to u16 leading to an unaligned access.
> Aligning the sup_multicast_addr to u16 boundary fixes the issue.
>
> Signed-off-by: Andreas Oetken <andreas.oetken@siemens.com>
>
> [...]
Here is the summary with links:
- [v1] net: hsr: align sup_multicast_addr in struct hsr_priv to u16 boundary
https://git.kernel.org/netdev/net/c/6c9f18f294c4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-02 17:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-02 9:03 [PATCH v1] net: hsr: align sup_multicast_addr in struct hsr_priv to u16 boundary Andreas Oetken
2021-02-02 17:00 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2021-02-02 9:13 Andreas Oetken
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).