Re: [PATCH net-next v2 4/4] net: dpaa2: Use napi_alloc_frag_align() to avoid the memory waste

[Ioana Ciornei <ioana.ciornei@nxp.com>]

On Sun, Jan 31, 2021 at 03:44:26PM +0800, Kevin Hao wrote:
> The napi_alloc_frag_align() will guarantee that a correctly align
> buffer address is returned. So use this function to simplify the buffer
> alloc and avoid the unnecessary memory waste.
> 
> Signed-off-by: Kevin Hao <haokexin@gmail.com>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>

> ---
> v2: No change.
> 
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> index 41e225baf571..882b32a04f5e 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> @@ -764,12 +764,11 @@ static int dpaa2_eth_build_sg_fd(struct dpaa2_eth_priv *priv,
>  	/* Prepare the HW SGT structure */
>  	sgt_buf_size = priv->tx_data_offset +
>  		       sizeof(struct dpaa2_sg_entry) *  num_dma_bufs;
> -	sgt_buf = napi_alloc_frag(sgt_buf_size + DPAA2_ETH_TX_BUF_ALIGN);
> +	sgt_buf = napi_alloc_frag_align(sgt_buf_size, DPAA2_ETH_TX_BUF_ALIGN);
>  	if (unlikely(!sgt_buf)) {
>  		err = -ENOMEM;
>  		goto sgt_buf_alloc_failed;
>  	}
> -	sgt_buf = PTR_ALIGN(sgt_buf, DPAA2_ETH_TX_BUF_ALIGN);
>  	memset(sgt_buf, 0, sgt_buf_size);
>  
>  	sgt = (struct dpaa2_sg_entry *)(sgt_buf + priv->tx_data_offset);
> -- 
> 2.29.2
>