* [PATCH] dpaa2-eth: Simplify the calculation of variables
@ 2021-02-02 10:02 Jiapeng Chong
2021-02-02 12:33 ` Ioana Ciornei
2021-02-06 18:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2021-02-02 10:02 UTC (permalink / raw)
To: ioana.ciornei
Cc: ruxandra.radulescu, davem, linux, ast, daniel, hawk,
john.fastabend, andrii, kafai, songliubraving, yhs, kpsingh,
netdev, linux-kernel, bpf, Jiapeng Chong
Fix the following coccicheck warnings:
./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1651:36-38: WARNING
!A || A && B is equivalent to !A || B.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
index fb0bcd1..93f84c9 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -1648,7 +1648,7 @@ void dpaa2_eth_set_rx_taildrop(struct dpaa2_eth_priv *priv,
* CG taildrop threshold, so it won't interfere with it; we also
* want frames in non-PFC enabled traffic classes to be kept in check)
*/
- td.enable = !tx_pause || (tx_pause && pfc);
+ td.enable = !tx_pause || pfc;
if (priv->rx_cgtd_enabled == td.enable)
return;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dpaa2-eth: Simplify the calculation of variables
2021-02-02 10:02 [PATCH] dpaa2-eth: Simplify the calculation of variables Jiapeng Chong
@ 2021-02-02 12:33 ` Ioana Ciornei
2021-02-06 18:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Ioana Ciornei @ 2021-02-02 12:33 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Ioana Ciocoi Radulescu, davem@davemloft.net,
linux@armlinux.org.uk, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com, andrii@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
kpsingh@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
On Tue, Feb 02, 2021 at 06:02:37PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1651:36-38: WARNING
> !A || A && B is equivalent to !A || B.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> index fb0bcd1..93f84c9 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> @@ -1648,7 +1648,7 @@ void dpaa2_eth_set_rx_taildrop(struct dpaa2_eth_priv *priv,
> * CG taildrop threshold, so it won't interfere with it; we also
> * want frames in non-PFC enabled traffic classes to be kept in check)
> */
> - td.enable = !tx_pause || (tx_pause && pfc);
> + td.enable = !tx_pause || pfc;
> if (priv->rx_cgtd_enabled == td.enable)
> return;
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dpaa2-eth: Simplify the calculation of variables
2021-02-02 10:02 [PATCH] dpaa2-eth: Simplify the calculation of variables Jiapeng Chong
2021-02-02 12:33 ` Ioana Ciornei
@ 2021-02-06 18:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-02-06 18:40 UTC (permalink / raw)
To: Jiapeng Chong
Cc: ioana.ciornei, ruxandra.radulescu, davem, linux, ast, daniel,
hawk, john.fastabend, andrii, kafai, songliubraving, yhs, kpsingh,
netdev, linux-kernel, bpf
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 2 Feb 2021 18:02:37 +0800 you wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1651:36-38: WARNING
> !A || A && B is equivalent to !A || B.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>
> [...]
Here is the summary with links:
- dpaa2-eth: Simplify the calculation of variables
https://git.kernel.org/netdev/net-next/c/b91b3a211542
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-06 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-02 10:02 [PATCH] dpaa2-eth: Simplify the calculation of variables Jiapeng Chong
2021-02-02 12:33 ` Ioana Ciornei
2021-02-06 18:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).