From: Leon Romanovsky <leonro@nvidia.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next] inet: do not export inet_gro_{receive|complete}
Date: Tue, 2 Feb 2021 18:01:37 +0200 [thread overview]
Message-ID: <20210202160137.GD3264866@unreal> (raw)
In-Reply-To: <20210202154145.1568451-1-eric.dumazet@gmail.com>
On Tue, Feb 02, 2021 at 07:41:45AM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> inet_gro_receive() and inet_gro_complete() are part
> of GRO engine which can not be modular.
>
> Similarly, inet_gso_segment() does not need to be exported,
> being part of GSO stack.
>
> In other words, net/ipv6/ip6_offload.o is part of vmlinux,
> regardless of CONFIG_IPV6.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Leon Romanovsky <leonro@nvidia.com>
> ---
> net/ipv4/af_inet.c | 3 ---
> 1 file changed, 3 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2021-02-02 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 15:41 [PATCH net-next] inet: do not export inet_gro_{receive|complete} Eric Dumazet
2021-02-02 16:01 ` Leon Romanovsky [this message]
2021-02-03 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202160137.GD3264866@unreal \
--to=leonro@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).