From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A97BC433E0 for ; Tue, 2 Feb 2021 18:57:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C1F464EC1 for ; Tue, 2 Feb 2021 18:57:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239158AbhBBS50 (ORCPT ); Tue, 2 Feb 2021 13:57:26 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:14570 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237908AbhBBS4M (ORCPT ); Tue, 2 Feb 2021 13:56:12 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 02 Feb 2021 10:55:32 -0800 Received: from localhost (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 2 Feb 2021 18:55:31 +0000 Date: Tue, 2 Feb 2021 18:01:37 +0200 From: Leon Romanovsky To: Eric Dumazet CC: "David S . Miller" , Jakub Kicinski , netdev , Eric Dumazet Subject: Re: [PATCH net-next] inet: do not export inet_gro_{receive|complete} Message-ID: <20210202160137.GD3264866@unreal> References: <20210202154145.1568451-1-eric.dumazet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210202154145.1568451-1-eric.dumazet@gmail.com> X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612292132; bh=d+QSK2YAfLOCuLB7Rzwq3/offIIWiA/L71zLLk8zUhk=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To:X-Originating-IP: X-ClientProxiedBy; b=G6A3IbV6qn41fnIjREgPUL5zhA9Z+KDd7/lFS4Np8xG43JBpEJX/pru54i+HjSIL1 rJiEVfa6aU7L4BS1V8JRVJ85gPhLPHpnrHOudm74aFJl/8R7KYmPIarAehYTCdnVnu g1eRv4BabmyMbrrX9779w9RXUwfz87x7A5+i5VCTG2GzcF5F0sh8/LKlH6LQeWxNPg bdbULCrCKgSweGpVCA4vE2BIcl6tCJJwA3IaZm5rjk/6UqdyhepXLLKlC2wwahYMWw PNH+vYu+LJQ8aF2ahimv5gToX0Fhbbm/694OYr4lr2mk41cmKLG7Iqafelk5CTEWUR o/ZgmMDDEUAfQ== Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 02, 2021 at 07:41:45AM -0800, Eric Dumazet wrote: > From: Eric Dumazet > > inet_gro_receive() and inet_gro_complete() are part > of GRO engine which can not be modular. > > Similarly, inet_gso_segment() does not need to be exported, > being part of GSO stack. > > In other words, net/ipv6/ip6_offload.o is part of vmlinux, > regardless of CONFIG_IPV6. > > Signed-off-by: Eric Dumazet > Cc: Leon Romanovsky > --- > net/ipv4/af_inet.c | 3 --- > 1 file changed, 3 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky