[PATCH net-next] inet: do not export inet_gro_{receive|complete}

[PATCH net-next] inet: do not export inet_gro_{receive|complete}

[Eric Dumazet]

From: Eric Dumazet <edumazet@google.com>

inet_gro_receive() and inet_gro_complete() are part
of GRO engine which can not be modular.

Similarly, inet_gso_segment() does not need to be exported,
being part of GSO stack.

In other words, net/ipv6/ip6_offload.o is part of vmlinux,
regardless of CONFIG_IPV6.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Leon Romanovsky <leonro@nvidia.com>
---
 net/ipv4/af_inet.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index b94fa8eb831bf3b18917529ef6a9263edb968592..be43c8d95af56624c4deee30e5f737eacdb884c1 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1419,7 +1419,6 @@ struct sk_buff *inet_gso_segment(struct sk_buff *skb,
 out:
 	return segs;
 }
-EXPORT_SYMBOL(inet_gso_segment);
 
 static struct sk_buff *ipip_gso_segment(struct sk_buff *skb,
 					netdev_features_t features)
@@ -1550,7 +1549,6 @@ struct sk_buff *inet_gro_receive(struct list_head *head, struct sk_buff *skb)
 
 	return pp;
 }
-EXPORT_SYMBOL(inet_gro_receive);
 
 static struct sk_buff *ipip_gro_receive(struct list_head *head,
 					struct sk_buff *skb)
@@ -1636,7 +1634,6 @@ int inet_gro_complete(struct sk_buff *skb, int nhoff)
 
 	return err;
 }
-EXPORT_SYMBOL(inet_gro_complete);
 
 static int ipip_gro_complete(struct sk_buff *skb, int nhoff)
 {
-- 
2.30.0.365.g02bc693789-goog

Re: [PATCH net-next] inet: do not export inet_gro_{receive|complete}

[Leon Romanovsky]

On Tue, Feb 02, 2021 at 07:41:45AM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> inet_gro_receive() and inet_gro_complete() are part
> of GRO engine which can not be modular.
>
> Similarly, inet_gso_segment() does not need to be exported,
> being part of GSO stack.
>
> In other words, net/ipv6/ip6_offload.o is part of vmlinux,
> regardless of CONFIG_IPV6.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Leon Romanovsky <leonro@nvidia.com>
> ---
>  net/ipv4/af_inet.c | 3 ---
>  1 file changed, 3 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

Re: [PATCH net-next] inet: do not export inet_gro_{receive|complete}

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue,  2 Feb 2021 07:41:45 -0800 you wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> inet_gro_receive() and inet_gro_complete() are part
> of GRO engine which can not be modular.
> 
> Similarly, inet_gso_segment() does not need to be exported,
> being part of GSO stack.
> 
> [...]

Here is the summary with links:
  - [net-next] inet: do not export inet_gro_{receive|complete}
    https://git.kernel.org/netdev/net-next/c/fca23f37f3a7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html