netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Ahmed S. Darwish" <a.darwish@linutronix.de>
Subject: Re: [PATCH 0/2] chelsio: cxgb: Use threaded interrupts for deferred work
Date: Tue, 2 Feb 2021 17:31:23 -0800	[thread overview]
Message-ID: <20210202173123.00001840@intel.com> (raw)
In-Reply-To: <20210202170104.1909200-1-bigeasy@linutronix.de>

Sebastian Andrzej Siewior wrote:

> Patch #2 fixes an issue in which del_timer_sync() and tasklet_kill() is
> invoked from the interrupt handler. This is probably a rare error case
> since it disables interrupts / the card in that case.
> Patch #1 converts a worker to use a threaded interrupt which is then
> also used in patch #2 instead adding another worker for this task (and
> flush_work() to synchronise vs rmmod).
> 
> This has been only compile tested.

Hi! Thanks for your patch. Do all drivers that use worker threads need
to convert like this or only some?

In future revisions, please indicate the tree
you're targeting, net or net-next.  ie [PATCH net-next v1] I'd also
invert the two paragraphs and talk about patch #1 first.

Jesse

  parent reply	other threads:[~2021-02-03  1:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02 17:01 [PATCH 0/2] chelsio: cxgb: Use threaded interrupts for deferred work Sebastian Andrzej Siewior
2021-02-02 17:01 ` [PATCH 1/2] chelsio: cxgb: Replace the workqueue with threaded interrupt Sebastian Andrzej Siewior
2021-02-02 17:01 ` [PATCH 2/2] chelsio: cxgb: Disable the card on error in " Sebastian Andrzej Siewior
2021-02-03  1:31 ` Jesse Brandeburg [this message]
2021-02-03  9:03   ` [PATCH 0/2] chelsio: cxgb: Use threaded interrupts for deferred work Sebastian Andrzej Siewior
2021-02-04  1:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210202173123.00001840@intel.com \
    --to=jesse.brandeburg@intel.com \
    --cc=a.darwish@linutronix.de \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).