From: Danielle Ratson <danieller@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <jiri@nvidia.com>,
<andrew@lunn.ch>, <f.fainelli@gmail.com>, <mkubecek@suse.cz>,
<mlxsw@nvidia.com>, <idosch@nvidia.com>,
Danielle Ratson <danieller@nvidia.com>
Subject: [PATCH net-next v4 0/8] Support setting lanes via ethtool
Date: Tue, 2 Feb 2021 20:06:04 +0200 [thread overview]
Message-ID: <20210202180612.325099-1-danieller@nvidia.com> (raw)
Some speeds can be achieved with different number of lanes. For example,
100Gbps can be achieved using two lanes of 50Gbps or four lanes of
25Gbps. This patchset adds a new selector that allows ethtool to
advertise link modes according to their number of lanes and also force a
specific number of lanes when autonegotiation is off.
Advertising all link modes with a speed of 100Gbps that use two lanes:
$ ethtool -s swp1 speed 100000 lanes 2 autoneg on
Forcing a speed of 100Gbps using four lanes:
$ ethtool -s swp1 speed 100000 lanes 4 autoneg off
Patchset overview:
Patch #1-#2 allows user space to configure the desired number of lanes.
Patch #3-#4 adjusts ethtool to dump to user space the number of lanes
currently in use.
Patches #5-#7 add support for lanes configuration in mlxsw.
Patch #8 adds a selftest.
v4:
* Add patch #1 for validating parameters before rtnl_lock().
v3:
* Patch #1: Change ethtool_ops.capabilities to be a bitfield,
and set min and max for the lanes policy.
* Patch #2: Remove LINK_MODE_UNKNOWN and move the speed, duplex
and lanes derivation to the wrapper
__ethtool_get_link_ksettings().
* Patch #5: Set the bitfield of supporting lanes in the driver
* to 'true'.
* Patch #7: Move the test to drivers/net/mlxsw.
v2:
* Patch #1: Remove ETHTOOL_LANES defines and simply use a number
instead.
* Patches #2,#6: Pass link mode from driver to ethtool instead
* of the parameters themselves.
* Patch #5: Add an actual width field for spectrum-2 link modes
in order to set the suitable link mode when lanes parameter is
passed.
* Patch #6: Changed lanes to be unsigned in
'struct link_mode_info'.
* Patch #7: Remove the test for recieving max_width when lanes
is not set by user. When not setting lanes, we don't promise
anything regarding what number of lanes will be chosen.
Danielle Ratson (8):
ethtool: Validate master slave configuration before rtnl_lock()
ethtool: Extend link modes settings uAPI with lanes
ethtool: Get link mode in use instead of speed and duplex parameters
ethtool: Expose the number of lanes in use
mlxsw: ethtool: Remove max lanes filtering
mlxsw: ethtool: Add support for setting lanes when autoneg is off
mlxsw: ethtool: Pass link mode in use to ethtool
net: selftests: Add lanes setting test
Documentation/networking/ethtool-netlink.rst | 11 +-
.../net/ethernet/mellanox/mlxsw/spectrum.h | 13 +-
.../mellanox/mlxsw/spectrum_ethtool.c | 196 ++++++++++-------
include/linux/ethtool.h | 5 +
include/uapi/linux/ethtool_netlink.h | 1 +
net/ethtool/common.c | 147 +++++++++++++
net/ethtool/common.h | 7 +
net/ethtool/ioctl.c | 18 +-
net/ethtool/linkmodes.c | 208 ++++++------------
net/ethtool/netlink.h | 2 +-
.../drivers/net/mlxsw/ethtool_lanes.sh | 187 ++++++++++++++++
.../selftests/net/forwarding/ethtool_lib.sh | 34 +++
tools/testing/selftests/net/forwarding/lib.sh | 28 +++
13 files changed, 626 insertions(+), 231 deletions(-)
create mode 100755 tools/testing/selftests/drivers/net/mlxsw/ethtool_lanes.sh
--
2.26.2
next reply other threads:[~2021-02-02 18:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 18:06 Danielle Ratson [this message]
2021-02-02 18:06 ` [PATCH net-next v4 1/8] ethtool: Validate master slave configuration before rtnl_lock() Danielle Ratson
2021-02-02 18:06 ` [PATCH net-next v4 2/8] ethtool: Extend link modes settings uAPI with lanes Danielle Ratson
2021-02-02 18:06 ` [PATCH net-next v4 3/8] ethtool: Get link mode in use instead of speed and duplex parameters Danielle Ratson
2021-02-22 9:41 ` Eric Dumazet
2021-02-22 13:11 ` Danielle Ratson
2021-02-22 13:39 ` Andrew Lunn
2021-02-02 18:06 ` [PATCH net-next v4 4/8] ethtool: Expose the number of lanes in use Danielle Ratson
2021-02-02 18:06 ` [PATCH net-next v4 5/8] mlxsw: ethtool: Remove max lanes filtering Danielle Ratson
2021-02-02 18:06 ` [PATCH net-next v4 6/8] mlxsw: ethtool: Add support for setting lanes when autoneg is off Danielle Ratson
2021-02-02 18:06 ` [PATCH net-next v4 7/8] mlxsw: ethtool: Pass link mode in use to ethtool Danielle Ratson
2021-02-02 18:06 ` [PATCH net-next v4 8/8] net: selftests: Add lanes setting test Danielle Ratson
2021-02-02 19:54 ` [PATCH net-next v4 0/8] Support setting lanes via ethtool Edwin Peer
2021-02-04 4:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202180612.325099-1-danieller@nvidia.com \
--to=danieller@nvidia.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).