From: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
Dany Madden <drt@linux.ibm.com>, Lijun Pan <ljp@linux.ibm.com>,
Rick Lindsley <ricklind@linux.ibm.com>,
abdhalee@in.ibm.com
Subject: Re: [PATCH v2 2/2] ibmvnic: fix race with multiple open/close
Date: Wed, 3 Feb 2021 12:56:52 -0800 [thread overview]
Message-ID: <20210203205652.GA700270@us.ibm.com> (raw)
In-Reply-To: <CA+FuTSdRci4=fAza+L_-kUf9VkZnfUhWZ49-XHY8DiRuroSv3Q@mail.gmail.com>
Willem de Bruijn [willemdebruijn.kernel@gmail.com] wrote:
> On Wed, Feb 3, 2021 at 12:10 AM Sukadev Bhattiprolu
> <sukadev@linux.ibm.com> wrote:
> >
> > If two or more instances of 'ip link set' commands race and first one
> > already brings the interface up (or down), the subsequent instances
> > can simply return without redoing the up/down operation.
> >
> > Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
> > Reported-by: Abdul Haleem <abdhalee@in.ibm.com>
> > Tested-by: Abdul Haleem <abdhalee@in.ibm.com>
> > Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
> >
> > ---
> > Changelog[v2] For consistency with ibmvnic_open() use "goto out" and return
> > from end of function.
>
> Did you find the code path that triggers this?
Not yet. I need to find time on the system to repro/debug that
>
> In v1 we discussed how the usual ip link path should not call the
> driver twice based on IFF_UP.
Yes, we can hold this patch for now if necessary. Hopefully Patch 1/2 is
ok.
Sukadev
next prev parent reply other threads:[~2021-02-03 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 5:06 [PATCH v2 1/2] ibmvnic: fix a race between open and reset Sukadev Bhattiprolu
2021-02-03 5:06 ` [PATCH v2 2/2] ibmvnic: fix race with multiple open/close Sukadev Bhattiprolu
2021-02-03 18:40 ` Willem de Bruijn
2021-02-03 20:56 ` Sukadev Bhattiprolu [this message]
2021-02-06 18:45 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203205652.GA700270@us.ibm.com \
--to=sukadev@linux.ibm.com \
--cc=abdhalee@in.ibm.com \
--cc=drt@linux.ibm.com \
--cc=ljp@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ricklind@linux.ibm.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).