netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: Sasha Neftin <sasha.neftin@intel.com>,
	netdev@vger.kernel.org, sassmann@redhat.com,
	anthony.l.nguyen@intel.com
Subject: [PATCH net-next 02/15] igc: Remove igc_set_fw_version comment
Date: Wed,  3 Feb 2021 16:42:46 -0800	[thread overview]
Message-ID: <20210204004259.3662059-3-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20210204004259.3662059-1-anthony.l.nguyen@intel.com>

From: Sasha Neftin <sasha.neftin@intel.com>

i225 device not supported and do not plan to support
configuration of fw version string for ethtool

Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/igc/igc_ethtool.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index ec8cd69d4992..29da2710b500 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -544,7 +544,6 @@ static int igc_ethtool_set_eeprom(struct net_device *netdev,
 	if (ret_val == 0)
 		hw->nvm.ops.update(hw);
 
-	/* check if need: igc_set_fw_version(adapter); */
 	kfree(eeprom_buff);
 	return ret_val;
 }
-- 
2.26.2


  parent reply	other threads:[~2021-02-04  0:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  0:42 [PATCH net-next 00/15][pull request] 1GbE Intel Wired LAN Driver Updates 2021-02-03 Tony Nguyen
2021-02-04  0:42 ` [PATCH net-next 01/15] igc: Clean up nvm_operations structure Tony Nguyen
2021-02-04  0:42 ` Tony Nguyen [this message]
2021-02-04  0:42 ` [PATCH net-next 03/15] igc: Remove MULR mask define Tony Nguyen
2021-02-04  0:42 ` [PATCH net-next 04/15] igc: Add Host Good Packets Transmitted Count Tony Nguyen
2021-02-04  0:42 ` [PATCH net-next 05/15] igc: Expose the NVM version Tony Nguyen
2021-02-04  0:42 ` [PATCH net-next 06/15] igc: Expose the gPHY firmware version Tony Nguyen
2021-02-04  0:42 ` [PATCH net-next 07/15] igc: Prefer strscpy over strlcpy Tony Nguyen
2021-02-04  0:42 ` [PATCH net-next 08/15] igc: Remove unused local receiver mask Tony Nguyen
2021-02-04  0:42 ` [PATCH net-next 09/15] igc: Remove unused FUNC_1 mask Tony Nguyen
2021-02-04  0:42 ` [PATCH net-next 10/15] igc: Fix TDBAL register show incorrect value Tony Nguyen
2021-02-04  0:42 ` [PATCH net-next 11/15] igb: fix " Tony Nguyen
2021-02-04  0:42 ` [PATCH net-next 12/15] igb: Enable RSS for Intel I211 Ethernet Controller Tony Nguyen
2021-02-04  0:42 ` [PATCH net-next 13/15] igb: remove h from printk format specifier Tony Nguyen
2021-02-04  0:42 ` [PATCH net-next 14/15] e1000e: remove the redundant value assignment in e1000_update_nvm_checksum_spt Tony Nguyen
2021-02-04  0:42 ` [PATCH net-next 15/15] e1000: drop unneeded assignment in e1000_set_itr() Tony Nguyen
2021-02-05  5:40 ` [PATCH net-next 00/15][pull request] 1GbE Intel Wired LAN Driver Updates 2021-02-03 patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204004259.3662059-3-anthony.l.nguyen@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sasha.neftin@intel.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).