* [PATCH net-next] net: core: Return the correct errno code
@ 2021-02-04 3:19 Zheng Yongjun
2021-02-06 19:20 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2021-02-04 3:19 UTC (permalink / raw)
To: davem, kuba, netdev, linux-kernel; +Cc: Zheng Yongjun
When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
net/core/rtnetlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 7d7223691783..6df8fb25668b 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -177,7 +177,7 @@ static int rtnl_register_internal(struct module *owner,
struct rtnl_link *link, *old;
struct rtnl_link __rcu **tab;
int msgindex;
- int ret = -ENOBUFS;
+ int ret = -ENOMEM;
BUG_ON(protocol < 0 || protocol > RTNL_FAMILY_MAX);
msgindex = rtm_msgindex(msgtype);
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: core: Return the correct errno code
2021-02-04 3:19 [PATCH net-next] net: core: Return the correct errno code Zheng Yongjun
@ 2021-02-06 19:20 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2021-02-06 19:20 UTC (permalink / raw)
To: Zheng Yongjun; +Cc: davem, netdev, linux-kernel
On Thu, 4 Feb 2021 11:19:23 +0800 Zheng Yongjun wrote:
> When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> net/core/rtnetlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 7d7223691783..6df8fb25668b 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -177,7 +177,7 @@ static int rtnl_register_internal(struct module *owner,
> struct rtnl_link *link, *old;
> struct rtnl_link __rcu **tab;
> int msgindex;
> - int ret = -ENOBUFS;
> + int ret = -ENOMEM;
while at it please move the line above int msgindex; so that variable
lines are sorted longest to shortest.
> BUG_ON(protocol < 0 || protocol > RTNL_FAMILY_MAX);
> msgindex = rtm_msgindex(msgtype);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-06 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-04 3:19 [PATCH net-next] net: core: Return the correct errno code Zheng Yongjun
2021-02-06 19:20 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).