From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: kuba@kernel.org, davem@davemloft.net,
willemdebruijn.kernel@gmail.com, netdev@vger.kernel.org,
stranche@codeaurora.org, subashab@codeaurora.org
Subject: Re: [PATCH net-next v5 1/2] net: mhi-net: Add re-aggregation of fragmented packets
Date: Thu, 4 Feb 2021 11:17:13 -0800 [thread overview]
Message-ID: <20210204111713.00005fb6@intel.com> (raw)
In-Reply-To: <1612428002-12333-1-git-send-email-loic.poulain@linaro.org>
Loic Poulain wrote:
> When device side MTU is larger than host side MTU, the packets
> (typically rmnet packets) are split over multiple MHI transfers.
> In that case, fragments must be re-aggregated to recover the packet
> before forwarding to upper layer.
>
> A fragmented packet result in -EOVERFLOW MHI transaction status for
> each of its fragments, except the final one. Such transfer was
> previously considered as error and fragments were simply dropped.
>
> This change adds re-aggregation mechanism using skb chaining, via
> skb frag_list.
>
> A warning (once) is printed since this behavior usually comes from
> a misconfiguration of the device (e.g. modem MTU).
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
> v2: use zero-copy skb chaining instead of skb_copy_expand.
> v3: Fix nit in commit msg + remove misleading inline comment for frag_list
> v4: no change
> v5: reword/fix commit subject
>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2021-02-04 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 8:40 [PATCH net-next v5 1/2] net: mhi-net: Add re-aggregation of fragmented packets Loic Poulain
2021-02-04 8:40 ` [PATCH net-next v5 2/2] net: qualcomm: rmnet: Fix rx_handler for non-linear skbs Loic Poulain
2021-02-04 19:17 ` Jesse Brandeburg [this message]
2021-02-06 19:31 ` [PATCH net-next v5 1/2] net: mhi-net: Add re-aggregation of fragmented packets Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204111713.00005fb6@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=stranche@codeaurora.org \
--cc=subashab@codeaurora.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).