From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA90C433DB for ; Fri, 5 Feb 2021 01:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A1C064FA3 for ; Fri, 5 Feb 2021 01:09:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232545AbhBEBJe (ORCPT ); Thu, 4 Feb 2021 20:09:34 -0500 Received: from mga09.intel.com ([134.134.136.24]:30707 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232263AbhBEBJa (ORCPT ); Thu, 4 Feb 2021 20:09:30 -0500 IronPort-SDR: UlNY7Xq9Ryi8uj4H2WO0xTzHYU0k4maPRvuAwX/ZN9fRMhD+jUg6p+SIAlES9b/EeOkLz1rXDQ CTU8PASWGVHg== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="181505413" X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="181505413" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 17:08:49 -0800 IronPort-SDR: rSfRk5qnf8S7RAXfEShK9dRTrJv8e2F2Uvfi8eVy379xAp/EEV6qVAXAJ39lCYB+uOohpQ5kLa 1y52B6iOCZvg== X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="393623628" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.212.188.246]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 17:08:49 -0800 Date: Thu, 4 Feb 2021 17:08:48 -0800 From: Jesse Brandeburg To: Song Yoong Siang Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , "Maxime Coquelin" , , , , , "Ong Boon Leong" , Voon Wei Feng , Wong Vee Khee , Gomes Vinicius Subject: Re: [PATCH net 1/1] net: stmmac: set TxQ mode back to DCB after disabling CBS Message-ID: <20210204170848.00000aff@intel.com> In-Reply-To: <1612447396-20351-1-git-send-email-yoong.siang.song@intel.com> References: <1612447396-20351-1-git-send-email-yoong.siang.song@intel.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Song Yoong Siang wrote: > From: Mohammad Athari Bin Ismail > > When disable CBS, mode_to_use parameter is not updated even the operation > mode of Tx Queue is changed to Data Centre Bridging (DCB). Therefore, > when tc_setup_cbs() function is called to re-enable CBS, the operation > mode of Tx Queue remains at DCB, which causing CBS fails to work. > > This patch updates the value of mode_to_use parameter to MTL_QUEUE_DCB > after operation mode of Tx Queue is changed to DCB in stmmac_dma_qmode() > callback function. > > Fixes: 1f705bc61aee ("net: stmmac: Add support for CBS QDISC") > Suggested-by: Gomes, Vinicius > Signed-off-by: Mohammad Athari Bin Ismail > Signed-off-by: Song, Yoong Siang Reviewed-by: Jesse Brandeburg