From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 427E3C433DB for ; Fri, 5 Feb 2021 01:14:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC9E160230 for ; Fri, 5 Feb 2021 01:14:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232498AbhBEBOC (ORCPT ); Thu, 4 Feb 2021 20:14:02 -0500 Received: from mga07.intel.com ([134.134.136.100]:38383 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230037AbhBEBOC (ORCPT ); Thu, 4 Feb 2021 20:14:02 -0500 IronPort-SDR: ZtNiZpLBsYRdDrDo/DJVnFEsBTpvWf3uACMIZzXtynmu5j8MfaRf42lPAr8i6sdsVXyGVh6MqG QNX7sYk7TVuA== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="245429282" X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="245429282" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 17:13:21 -0800 IronPort-SDR: Hhjyo0KJK2CEHDLbW/gEdYDOeP9zgke8bAFigVsQRKDVLj3wngL5W341XQ4iVZeEMh4YK7IfnC wQT9epFeEpiA== X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="393624785" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.212.188.246]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 17:13:20 -0800 Date: Thu, 4 Feb 2021 17:13:19 -0800 From: Jesse Brandeburg To: Vladimir Oltean Cc: "David S . Miller" , Jakub Kicinski , , Michael Walle , Claudiu Manoil , Alexandru Marginean Subject: Re: [PATCH net] net: enetc: initialize the RFS and RSS memories Message-ID: <20210204171319.00000c1b@intel.com> In-Reply-To: <20210204134511.2640309-1-vladimir.oltean@nxp.com> References: <20210204134511.2640309-1-vladimir.oltean@nxp.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Vladimir Oltean wrote: > Discussion with the hardware design engineers reveals that on LS1028A, > the hardware does not do initialization of that RFS/RSS memory, and that > software should clear/initialize the entire table before starting to > operate. That comes as a bit of a surprise, since the driver does not do > initialization of the RFS memory. Also, the initialization of the > Receive Side Scaling is done only partially. ... > Reported-by: Michael Walle > Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drivers") > Signed-off-by: Vladimir Oltean Reviewed-by: Jesse Brandeburg