From: Marcelo Ricardo Leitner <mleitner@redhat.com>
To: wenxu <wenxu@ucloud.cn>
Cc: i.maximets@ovn.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] net/sched: cls_flower: Return invalid for unknown ct_state flags rules
Date: Thu, 4 Feb 2021 15:23:10 -0300 [thread overview]
Message-ID: <20210204182310.GN3399@horizon.localdomain> (raw)
In-Reply-To: <ef18cecf-f3ff-28b2-c53d-049722843c6d@ucloud.cn>
On Thu, Feb 04, 2021 at 11:50:53PM +0800, wenxu wrote:
>
> 在 2021/2/4 21:38, Marcelo Ricardo Leitner 写道:
> > Hi,
> >
> > On Thu, Feb 04, 2021 at 12:17:24PM +0800, wenxu@ucloud.cn wrote:
> >> From: wenxu <wenxu@ucloud.cn>
> >>
> >> Reject the unknown ct_state flags of cls flower rules. This also make
> >> the userspace like ovs to probe the ct_state flags support in the
> >> kernel.
> > That's a good start but it could also do some combination sanity
> > checks, like ovs does in validate_ct_state(). For example, it does:
> >
> > if (state && !(state & CS_TRACKED)) {
> > ds_put_format(ds, "%s: invalid connection state: "
> > "If \"trk\" is unset, no other flags are set\n",
> >
> So this sanity checks maybe also need to be added in the ovs kernel modules?
>
> The kernel datapath can work without ovs-vswitchd.
IMHO that would be nice, yes.
Marcelo
prev parent reply other threads:[~2021-02-04 18:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 4:17 [PATCH net] net/sched: cls_flower: Return invalid for unknown ct_state flags rules wenxu
2021-02-04 13:38 ` Marcelo Ricardo Leitner
2021-02-04 15:50 ` wenxu
2021-02-04 18:23 ` Marcelo Ricardo Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204182310.GN3399@horizon.localdomain \
--to=mleitner@redhat.com \
--cc=i.maximets@ovn.org \
--cc=netdev@vger.kernel.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).