netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Cc: netdev@vger.kernel.org, dsahern@gmail.com, jiri@nvidia.com,
	davem@davemloft.net, linux-kernel@vger.kernel.org,
	kuba@kernel.org
Subject: Re: [PATCH iproute2-next V3] devlink: add support for port params get/set
Date: Fri, 5 Feb 2021 13:04:45 +0100	[thread overview]
Message-ID: <20210205120445.GF4652@nanopsycho.orion> (raw)
In-Reply-To: <20210202130445.5950-1-oleksandr.mazur@plvision.eu>

Tue, Feb 02, 2021 at 02:04:45PM CET, oleksandr.mazur@plvision.eu wrote:
>Add implementation for the port parameters
>getting/setting.
>Add bash completion for port param.
>Add man description for port param.
>
>Example:
>$ devlink dev param set netdevsim/netdevsim0/0 name test_port_parameter value false cmode runtime
>
>$ devlink port param show netdevsim/netdevsim0/0 name test_port_parameter
>netdevsim/netdevsim0/0:
>  name test_port_parameter type driver-specific
>    values:
>      cmode runtime value false
>
>$ devlink port  -jp param show netdevsim/netdevsim0/0 name test_port_parameter
>{
>    "param": {
>        "netdevsim/netdevsim0/0": [ {
>                "name": "test_port_parameter",
>                "type": "driver-specific",
>                "values": [ {
>                        "cmode": "runtime",
>                        "value": false
>                    } ]
>            } ]
>    }
>}
>
>Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>

Looks fine.

Reviewed-by: Jiri Pirko <jiri@nvidia.com>

  parent reply	other threads:[~2021-02-05 12:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02 13:04 [PATCH iproute2-next V3] devlink: add support for port params get/set Oleksandr Mazur
2021-02-05  4:38 ` David Ahern
2021-02-05 12:04 ` Jiri Pirko [this message]
2021-02-08 15:41 ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210205120445.GF4652@nanopsycho.orion \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oleksandr.mazur@plvision.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).