From: Danielle Ratson <danieller@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <mkubecek@suse.cz>, <f.fainelli@gmail.com>, <kuba@kernel.org>,
<andrew@lunn.ch>, <mlxsw@nvidia.com>,
Danielle Ratson <danieller@mellanox.com>
Subject: [PATCH ethtool v3 2/5] netlink: settings: Add netlink support for lanes parameter
Date: Wed, 10 Feb 2021 15:48:37 +0200 [thread overview]
Message-ID: <20210210134840.2187696-3-danieller@nvidia.com> (raw)
In-Reply-To: <20210210134840.2187696-1-danieller@nvidia.com>
From: Danielle Ratson <danieller@mellanox.com>
Add support for "ethtool -s <dev> lanes N ..." for setting a specific
number of lanes.
Signed-off-by: Danielle Ratson <danieller@mellanox.com>
---
Notes:
v3:
* Remove a leftover.
* After adding a seperated patch for uapi headers, squash rest of
the first patch.
ethtool.c | 1 +
netlink/desc-ethtool.c | 1 +
netlink/settings.c | 7 +++++++
3 files changed, 9 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index fb90e9e..a8339c8 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -5620,6 +5620,7 @@ static const struct option args[] = {
.nlfunc = nl_sset,
.help = "Change generic options",
.xhelp = " [ speed %d ]\n"
+ " [ lanes %d ]\n"
" [ duplex half|full ]\n"
" [ port tp|aui|bnc|mii|fibre|da ]\n"
" [ mdix auto|on|off ]\n"
diff --git a/netlink/desc-ethtool.c b/netlink/desc-ethtool.c
index 96291b9..fe5d7ba 100644
--- a/netlink/desc-ethtool.c
+++ b/netlink/desc-ethtool.c
@@ -87,6 +87,7 @@ static const struct pretty_nla_desc __linkmodes_desc[] = {
NLATTR_DESC_U8(ETHTOOL_A_LINKMODES_DUPLEX),
NLATTR_DESC_U8(ETHTOOL_A_LINKMODES_MASTER_SLAVE_CFG),
NLATTR_DESC_U8(ETHTOOL_A_LINKMODES_MASTER_SLAVE_STATE),
+ NLATTR_DESC_U32(ETHTOOL_A_LINKMODES_LANES),
};
static const struct pretty_nla_desc __linkstate_desc[] = {
diff --git a/netlink/settings.c b/netlink/settings.c
index 90c28b1..c54fe56 100644
--- a/netlink/settings.c
+++ b/netlink/settings.c
@@ -1067,6 +1067,13 @@ static const struct param_parser sset_params[] = {
.handler = nl_parse_direct_u32,
.min_argc = 1,
},
+ {
+ .arg = "lanes",
+ .group = ETHTOOL_MSG_LINKMODES_SET,
+ .type = ETHTOOL_A_LINKMODES_LANES,
+ .handler = nl_parse_direct_u32,
+ .min_argc = 1,
+ },
{
.arg = "duplex",
.group = ETHTOOL_MSG_LINKMODES_SET,
--
2.26.2
next prev parent reply other threads:[~2021-02-10 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 13:48 [PATCH ethtool v3 0/5] Extend uAPI with lanes parameter Danielle Ratson
2021-02-10 13:48 ` [PATCH ethtool v3 1/5] update UAPI header copies Danielle Ratson
2021-02-10 13:48 ` Danielle Ratson [this message]
2021-02-10 13:48 ` [PATCH ethtool v3 3/5] netlink: settings: Expose the number of lanes in use Danielle Ratson
2021-02-10 13:48 ` [PATCH ethtool v3 4/5] shell-completion: Add completion for lanes Danielle Ratson
2021-02-10 13:48 ` [PATCH ethtool v3 5/5] man: Add man page for setting lanes parameter Danielle Ratson
2021-02-14 22:01 ` [PATCH ethtool v3 0/5] Extend uAPI with " Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210134840.2187696-3-danieller@nvidia.com \
--to=danieller@nvidia.com \
--cc=andrew@lunn.ch \
--cc=danieller@mellanox.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).