Re: [PATCH v2 net-next 2/4] dt-bindings: net: Add bindings for Qualcomm QCA807x

[Rob Herring <robh@kernel.org>]

On Wed, Feb 10, 2021 at 01:55:21PM +0100, Robert Marko wrote:
> Add DT bindings for Qualcomm QCA807x PHYs.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> ---
> Changes in v2:
> * Drop LED properties
> * Directly define PSGMII/QSGMII SerDes driver values
> 
>  .../devicetree/bindings/net/qcom,qca807x.yaml | 70 +++++++++++++++++++
>  1 file changed, 70 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/qcom,qca807x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,qca807x.yaml b/Documentation/devicetree/bindings/net/qcom,qca807x.yaml
> new file mode 100644
> index 000000000000..0867f5e698cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/qcom,qca807x.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/qcom,qca807x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm QCA807x PHY
> +
> +maintainers:
> +  - Robert Marko <robert.marko@sartura.hr>
> +
> +description: |
> +  Bindings for Qualcomm QCA807x PHYs
> +
> +allOf:
> +  - $ref: ethernet-phy.yaml#
> +
> +properties:
> +  reg:
> +    maxItems: 1
> +
> +  qcom,fiber-enable:
> +    description: |
> +      If present, then PHYs combo port is configured to operate in combo
> +      mode. In combo mode autodetection of copper and fiber media is
> +      used in order to support both of them.
> +      Combo mode can be strapped as well, if not strapped this property
> +      will set combo support anyway.
> +    type: boolean
> +
> +  qcom,psgmii-az:
> +    description: |
> +      If present, then PSMGII PHY will advertise 802.3-az support to
> +      the MAC.

Sounds like a standard thing that should be common?

> +    type: boolean
> +
> +  gpio-controller: true
> +  "#gpio-cells":
> +    const: 2
> +
> +  qcom,tx-driver-strength:
> +    description: PSGMII/QSGMII SerDes TX driver strength control in mV.

Use standard unit suffix as defined in property-units.txt.

Again, seems like a common property?

> +    $ref: /schemas/types.yaml#/definitions/uint32

Then you can drop this.

> +    enum: [140, 160, 180, 200, 220, 240, 260, 280, 300, 320, 400, 500, 600]
> +
> +  qcom,control-dac:
> +    description: Analog MDI driver amplitude and bias current.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [0, 1, 2, 3, 4, 5, 6, 7]
> +
> +required:
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/net/qcom-qca807x.h>
> +
> +    mdio {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      ethphy0: ethernet-phy@0 {
> +        compatible = "ethernet-phy-ieee802.3-c22";
> +        reg = <0>;
> +
> +        qcom,control-dac = <QCA807X_CONTROL_DAC_DSP_VOLT_QUARTER_BIAS>;
> +      };
> +    };
> -- 
> 2.29.2
>