From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 777A7C433E0 for ; Fri, 12 Feb 2021 07:11:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41B9864E2D for ; Fri, 12 Feb 2021 07:11:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229714AbhBLHL2 (ORCPT ); Fri, 12 Feb 2021 02:11:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43077 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229598AbhBLHLZ (ORCPT ); Fri, 12 Feb 2021 02:11:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613113777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8mhZkZKs20diLxFUzToHk7jnGcTrrMDi8W9COCWFWPI=; b=gRyiIMFfypXdP5OgiwUqpTWzuiAdVf9p9MK53pVLy7AVojCT9zC8cnr9PK/OfLoiGF3XU7 yJfmSRDzQKXlzpd9M+go0TXiegio4HJ0OrY/bIr33gNbYW6Ffp9WXB78d5tBczpcixfp7h PWFmZSPTAW9vJ4NNlyBxZcmsr78Q+l8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-207-Ez5cxZ2cNsejTNSpLWHGAg-1; Fri, 12 Feb 2021 02:09:34 -0500 X-MC-Unique: Ez5cxZ2cNsejTNSpLWHGAg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 91510192AB79; Fri, 12 Feb 2021 07:09:33 +0000 (UTC) Received: from carbon (unknown [10.36.110.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id C3ABD7093A; Fri, 12 Feb 2021 07:09:28 +0000 (UTC) Date: Fri, 12 Feb 2021 08:09:27 +0100 From: Jesper Dangaard Brouer To: Igor Russkikh Cc: "netdev@vger.kernel.org" , "David S . Miller" , brouer@redhat.com, "Daniel T. Lee" Subject: Re: [EXT] Re: [PATCH v2 net-next 1/2] samples: pktgen: allow to specify delay parameter via new opt Message-ID: <20210212080927.008fd4c8@carbon> In-Reply-To: References: <20210211155626.25213-1-irusskikh@marvell.com> <20210211155626.25213-2-irusskikh@marvell.com> <20210211181211.5c2d61b0@carbon> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 11 Feb 2021 17:39:35 +0000 Igor Russkikh wrote: > >> + echo " -w : (\$DELAY) Tx Delay value (us)" > >This is not in "us" it is in "ns" (nanosec). (Like I pointed out last time...) > > Ah, sorry lost that. Will fix. Also remember that you made similar mistake in next patch. When adding documentation in samples/pktgen/README.rst. Strictly speaking, the doc update for DELAY belongs in patch-1. > One extra thing I wanted to raise is "set -o errexit" in functions.sh. > It basically contradicts with the usecase I'm using (doing source ./functions.sh). > After that, any error in current shell makes it to quit. Cc. Daniel T. Lee, can you remember why this 'errexit' was added? > Honestly, for my tests, I do always disable that line. In your shell script, using "append", you can disable that shell feature in your script (instead of removing the line from functions.sh). -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer