* [PATCH net] ibmvnic: change IBMVNIC_MAX_IND_DESCS to 16
@ 2021-02-12 16:17 Dany Madden
2021-02-12 18:53 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Dany Madden @ 2021-02-12 16:17 UTC (permalink / raw)
To: netdev; +Cc: sukadev, ljp, ricklind, Dany Madden
The supported indirect subcrq entries on Power8 is 16. Power9
supports 128. Redefined this value to 16 to minimize the driver from
having to reset when migrating between Power9 and Power8. In our rx/tx
performance testing, we found no performance difference between 16 and
128 at this time.
Fixes: f019fb6392e5 ("ibmvnic: Introduce indirect subordinate Command Response Queue buffers")
Signed-off-by: Dany Madden <drt@linux.ibm.com>
---
drivers/net/ethernet/ibm/ibmvnic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.h b/drivers/net/ethernet/ibm/ibmvnic.h
index c09c3f6bba9f..07ced1016aa4 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.h
+++ b/drivers/net/ethernet/ibm/ibmvnic.h
@@ -31,7 +31,7 @@
#define IBMVNIC_BUFFS_PER_POOL 100
#define IBMVNIC_MAX_QUEUES 16
#define IBMVNIC_MAX_QUEUE_SZ 4096
-#define IBMVNIC_MAX_IND_DESCS 128
+#define IBMVNIC_MAX_IND_DESCS 16
#define IBMVNIC_IND_ARR_SZ (IBMVNIC_MAX_IND_DESCS * 32)
#define IBMVNIC_TSO_BUF_SZ 65536
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] ibmvnic: change IBMVNIC_MAX_IND_DESCS to 16
2021-02-12 16:17 [PATCH net] ibmvnic: change IBMVNIC_MAX_IND_DESCS to 16 Dany Madden
@ 2021-02-12 18:53 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2021-02-12 18:53 UTC (permalink / raw)
To: Dany Madden; +Cc: netdev, sukadev, ljp, ricklind
On Fri, 12 Feb 2021 11:17:27 -0500 Dany Madden wrote:
> The supported indirect subcrq entries on Power8 is 16. Power9
> supports 128. Redefined this value to 16 to minimize the driver from
> having to reset when migrating between Power9 and Power8. In our rx/tx
> performance testing, we found no performance difference between 16 and
> 128 at this time.
>
> Fixes: f019fb6392e5 ("ibmvnic: Introduce indirect subordinate Command Response Queue buffers")
> Signed-off-by: Dany Madden <drt@linux.ibm.com>
Fixes tag: Fixes: f019fb6392e5 ("ibmvnic: Introduce indirect subordinate Command Response Queue buffers")
Has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-12 18:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-12 16:17 [PATCH net] ibmvnic: change IBMVNIC_MAX_IND_DESCS to 16 Dany Madden
2021-02-12 18:53 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).