From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
bpf@vger.kernel.org, Daniel Borkmann <borkmann@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
brouer@redhat.com
Subject: Re: [PATCH net-next V1] net: adjust net_device layout for cacheline usage
Date: Fri, 12 Feb 2021 16:57:32 +0100 [thread overview]
Message-ID: <20210212165732.77a34579@carbon> (raw)
In-Reply-To: <20210129120723.1e90ab42@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, 29 Jan 2021 12:07:23 -0800
Jakub Kicinski <kuba@kernel.org> wrote:
> On Fri, 29 Jan 2021 20:47:41 +0100 Eric Dumazet wrote:
> > On 1/29/21 8:35 PM, Jakub Kicinski wrote:
> >
> > > kdoc didn't complain, and as you say it's already a mess, plus it's
> > > two screen-fulls of scrolling away...
> > >
> > > I think converting to inline kdoc of members would be an improvement,
> > > if you want to sign up for that? Otherwise -EDIDNTCARE on my side :)
> > >
> >
> > What about removing this kdoc ?
> >
> > kdoc for a huge structure is mostly useless...
>
> It's definitely not useful for "us", I'd guess most seasoned developers
> will just grep for uses of the field - but maybe it is useful for noobs
> trying to have high-level sense of the code?
>
> Either way is fine by me, we can always preserve meaningful comments
> inline without the kdoc decorator.
I agree that removing this kdoc makes sense. But as Jakub says we
should preserve meaningful comments inline. I'll add this task to my
TODO list, but anyone feel free to do the work before I get around to it.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2021-02-12 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 17:39 [PATCH net-next V1] net: adjust net_device layout for cacheline usage Jesper Dangaard Brouer
2021-01-29 3:51 ` David Ahern
2021-01-29 7:58 ` Jesper Dangaard Brouer
[not found] ` <20210129114642.139cb7dc@carbon>
2021-01-29 19:35 ` Jakub Kicinski
2021-01-29 19:47 ` Eric Dumazet
2021-01-29 20:07 ` Jakub Kicinski
2021-02-12 15:57 ` Jesper Dangaard Brouer [this message]
2021-01-29 4:50 ` patchwork-bot+netdevbpf
[not found] ` <52835f1f-96e1-b36e-2631-1182649ac3a8@gmail.com>
[not found] ` <20210129150058.34e3a855@carbon>
2021-02-12 15:49 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212165732.77a34579@carbon \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox