From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 292C5C433E0 for ; Sun, 14 Feb 2021 20:44:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9CFD64E5E for ; Sun, 14 Feb 2021 20:44:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229901AbhBNUoE (ORCPT ); Sun, 14 Feb 2021 15:44:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbhBNUoB (ORCPT ); Sun, 14 Feb 2021 15:44:01 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3883C061574; Sun, 14 Feb 2021 12:43:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8XrvPZQ0HQjAVtIcZun5iSJlbNXch34tpLZqNY5Tl9M=; b=ykLd6Ls4yzh5r8UdIKPNRMsIb Zvwk8SKZTEGMvmCq56QumYWpCVZz3AOdDfZYR1j+VPs88AeiVI4t4O+ETWJ11BeuOQYiJkrRWCJTQ eTTkOyUbxuVr1fZNiGmZzg6LhrhMkPhblgb9dixYdh/+Fh46HT+3L4GTOdx3LQ7pKRe6cBk0o/CDz wsxWNUZP3sdRLRbMfHFUlvTGEIXOjyQh5YzCuobo4qxtso6Ki7wsZjx7twjpr2FsIlCyRi2QCD98b 0LAyjyzqD7x+ZAI9j4REMerEXm7GI0JPL5J3qT5PwtgWDKm4mjPjV4pep62gKjfAkqsC5JrmuYtNg fbY0tHH1Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:43430) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBOEY-0000ZL-TG; Sun, 14 Feb 2021 20:43:10 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lBOEU-0000yr-1p; Sun, 14 Feb 2021 20:43:06 +0000 Date: Sun, 14 Feb 2021 20:43:06 +0000 From: Russell King - ARM Linux admin To: Heiner Kallweit Cc: Jakub Kicinski , David Miller , Realtek linux nic maintainers , Andrew Lunn , Jonathan Corbet , Doug Berger , Florian Fainelli , Byungho An , "netdev@vger.kernel.org" , linux-doc@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH net-next] net: phy: rename PHY_IGNORE_INTERRUPT to PHY_MAC_INTERRUPT Message-ID: <20210214204305.GV1463@shell.armlinux.org.uk> References: <243316e1-1fa3-dcbb-f090-0ef504d5dec7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <243316e1-1fa3-dcbb-f090-0ef504d5dec7@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Feb 14, 2021 at 03:16:23PM +0100, Heiner Kallweit wrote: > Some internal PHY's have their events like link change reported by the > MAC interrupt. We have PHY_IGNORE_INTERRUPT to deal with this scenario. > I'm not too happy with this name. We don't ignore interrupts, typically > there is no interrupt exposed at a PHY level. So let's rename it to > PHY_MAC_INTERRUPT. This is in line with phy_mac_interrupt(), which is > called from the MAC interrupt handler to handle PHY events. > > Signed-off-by: Heiner Kallweit Reviewed-by: Russell King Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!