From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8622C433DB for ; Wed, 17 Feb 2021 12:44:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9036564E42 for ; Wed, 17 Feb 2021 12:44:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232729AbhBQMoF (ORCPT ); Wed, 17 Feb 2021 07:44:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232663AbhBQMnY (ORCPT ); Wed, 17 Feb 2021 07:43:24 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBB1CC06178A for ; Wed, 17 Feb 2021 04:42:42 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id b14so15858902eju.7 for ; Wed, 17 Feb 2021 04:42:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oJPm2B/oNL3KwOlSQNUjt7Mntse6JdaGaAAqn/p87mk=; b=gG0+pDnjFoVRpaS8WgVTWvW/kmFl4eUmplDahBS+rwJ46BDZX41pxnKJ5JtEPTMKtk VDgsWwG9TdOlrJFcD0Phd2T6KcXqPqdwBPZmE/egrehKMEBuAvxTP454DMjhpiiPqV9X ey3mQcLCw7ZBCR59HlT/N+saYsAKOCLueRu304ta4XNuhpbERE4k+V3Gwu1yVNJcPVks hHUatdMpR8XLxEVBYzA+1zVcMFXJ2069+Z6+m2Clw5wgFD+QB5sBcBzXyNuX1hsk5ke/ +Hm7N7Dn9b39i9KIGk1LDcfruNibqI8OXV5mIKjg3gYGp+jA/vCBcleE3gKBn5GZqwh4 kkWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oJPm2B/oNL3KwOlSQNUjt7Mntse6JdaGaAAqn/p87mk=; b=lj6RBN2KUQ9b5e+lNsH4gg0j12F2l4/pp9vQcHkR+BGehjJCchJLbXL2Xi+94ssH+2 MQq+ug80H8iIPz0qL7KDfPr7cdTpEbs4RECMbMkpLmTUewwOZy/8Ic9aUTMAV5NmVn+L +XIOfvpdVEBCTEfhwVJpGDQbWOI9ul4P55hFtMcjoZc8XJggxoSU9b6zm/Lb7gmmTSqv L1IpqwFvr9S+w2EekEA55nnGt0aM0YfNXb063wgF01lEK4d05Z/X6cHY6y3pLWObNX97 W1tSlIF4pZDN8luzJ/s6npFWvHCp52rMOhPDE11VXtKWJ+QP/1D1OHVaIyiiq010o5Sk zezw== X-Gm-Message-State: AOAM533JTaZe5UKxfa5DABW0laaAqK/+PMA7TlsUmGoYVzzMp8SCaXOo IC8RGDvoOY/6AQeJV8clfuk= X-Google-Smtp-Source: ABdhPJzde5IeuVBEf947PbMNcXc+Nf2/gLLGh26DFdv7nEDGGScLhmbFAlBg1e8epFxbbLhWM1WICw== X-Received: by 2002:a17:906:a57:: with SMTP id x23mr24931999ejf.40.1613565761566; Wed, 17 Feb 2021 04:42:41 -0800 (PST) Received: from skbuf ([188.25.217.13]) by smtp.gmail.com with ESMTPSA id 62sm1101278edc.46.2021.02.17.04.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 04:42:41 -0800 (PST) Date: Wed, 17 Feb 2021 14:42:39 +0200 From: Vladimir Oltean To: DENG Qingfang Cc: Linus Walleij , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" , Jakub Kicinski , netdev , Mauri Sandberg Subject: Re: [PATCH] net: dsa: tag_rtl4_a: Support also egress tags Message-ID: <20210217124239.sxgkhow53vox7o54@skbuf> References: <20210216235542.2718128-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 17, 2021 at 08:38:30PM +0800, DENG Qingfang wrote: > On Wed, Feb 17, 2021 at 7:55 AM Linus Walleij wrote: > > + > > + /* Pad out to at least 60 bytes */ > > + if (unlikely(eth_skb_pad(skb))) > > + return NULL; > > I just found that this will cause double free (eth_skb_pad will free > the skb if allocation fails, and dsa_slave_xmit will still try to free > it because it returns NULL. > Replace eth_skb_pad(skb) with __skb_put_padto(skb, ETH_ZLEN, false) to > avoid that. Good catch, Qingfang.