From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: brouer@redhat.com, netdev@vger.kernel.org,
Camelia Groza <camelia.groza@nxp.com>,
Madalin Bucur <madalin.bucur@nxp.com>,
Jakub Kicinski <kuba@kernel.org>,
kernel@pengutronix.de, Ioana Ciornei <ioana.ciornei@nxp.com>,
Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH] Revert "dpaa_eth: add XDP_REDIRECT support"
Date: Thu, 18 Feb 2021 12:42:40 +0100 [thread overview]
Message-ID: <20210218124240.5198dcda@carbon> (raw)
In-Reply-To: <20210217151758.5622-1-s.hauer@pengutronix.de>
On Wed, 17 Feb 2021 16:17:58 +0100
Sascha Hauer <s.hauer@pengutronix.de> wrote:
> This reverts commit a1e031ffb422bb89df9ad9c018420d0deff7f2e3.
>
> This commit introduces a:
>
> np = container_of(&portal, struct dpaa_napi_portal, p);
>
> Using container_of() on the address of a pointer doesn't make sense as
> the pointer is not embedded into the desired struct.
>
> KASAN complains about it like this:
>
> [ 17.703277] ==================================================================
> [ 17.710517] BUG: KASAN: stack-out-of-bounds in rx_default_dqrr+0x994/0x14a0
> [ 17.717504] Read of size 4 at addr ffff0009336495fc by task systemd/1
> [ 17.723955]
> [ 17.725447] CPU: 0 PID: 1 Comm: systemd Not tainted 5.11.0-rc6-20210204-2-00033-gfd6caa9c7514-dirty #63
> [ 17.734857] Hardware name: TQ TQMLS1046A SoM
> [ 17.742176] Call trace:
> [ 17.744621] dump_backtrace+0x0/0x2e8
> [ 17.748298] show_stack+0x1c/0x68
> [ 17.751622] dump_stack+0xe8/0x14c
> [ 17.755033] print_address_description.constprop.0+0x68/0x304
> [ 17.760794] kasan_report+0x1d4/0x238
> [ 17.764466] __asan_load4+0x88/0xc0
> [ 17.767962] rx_default_dqrr+0x994/0x14a0
> [ 17.771980] qman_p_poll_dqrr+0x254/0x278
> [ 17.776000] dpaa_eth_poll+0x4c/0xe0
> ...
>
> It's not clear to me how a the struct dpaa_napi_portal * should be
> derived from the struct qman_portal *, so revert the patch for now.
Can we please get a response from NXP people?
Are you saying XDP_REDIRECT feature is completely broken on dpaa driver?
(I only have access to dpaa2 hardware)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2021-02-18 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 15:17 [PATCH] Revert "dpaa_eth: add XDP_REDIRECT support" Sascha Hauer
2021-02-18 11:42 ` Jesper Dangaard Brouer [this message]
2021-02-18 13:43 ` Camelia Alexandra Groza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218124240.5198dcda@carbon \
--to=brouer@redhat.com \
--cc=camelia.groza@nxp.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ioana.ciornei@nxp.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).