From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 108FAC433DB for ; Tue, 23 Feb 2021 13:51:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C381564E4D for ; Tue, 23 Feb 2021 13:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232774AbhBWNu7 (ORCPT ); Tue, 23 Feb 2021 08:50:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:30539 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232585AbhBWNuz (ORCPT ); Tue, 23 Feb 2021 08:50:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614088168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GOvexyYc/ObMQAaHFdie5/nomXHMwOs8rdABZEM/9Ps=; b=K0ItB7EQyxic1DYoMmmsyQTV9a0z1KHzipxJc1w24WSzqQ3M30NkXl9hLs/EVxyukVuTtQ 9KGDAClM5/NvaXM6vtVK4HB8eLTF8L8V3xg+KuypfiiWntJJy+T/PL0zn0mHJQXwxtUFJv aIJX/iJXv+N0MCQszS0XKbBvn3dDuv0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-268-CiD_f7IWO8aWRLBBI70_bQ-1; Tue, 23 Feb 2021 08:49:24 -0500 X-MC-Unique: CiD_f7IWO8aWRLBBI70_bQ-1 Received: by mail-wm1-f72.google.com with SMTP id h16so1207979wmq.8 for ; Tue, 23 Feb 2021 05:49:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GOvexyYc/ObMQAaHFdie5/nomXHMwOs8rdABZEM/9Ps=; b=H5Z4igvIN68asgFD4VnhkNOg1m6jizeFQfj3vlnYz6ZqdiLbgNFxVDYkjXN5wdDgYD EP+Ut+zErdxNjEMa20AfX/ZWXlMqWduZdZqD2Y35imhGgu4nMbK3jUXVYstOs1ZS4CF/ 75//A8p/0zXTnfane68kTWcALOWDwMSyOFrClgtKpWhTnDgzdO5CCBo+Mzdsq9MEFHvt u5Hw6UvYW4BYeMVLFkqw85zLumgvPwYVmAAaXl5Q6tJIA7rE1QYRLLWKtMx2+//6cjl0 FgP+8igJOqJyOkxB+GxWMedsnmFYR3PsaLZViHK4ilccfwR/4a0ssKJp/cYs6F/nJ4LP XXjg== X-Gm-Message-State: AOAM530p72f4WvGcc85Topv5iwAVwmKf6DOwyvoiKIC7tpgXMLmGxqnK 0RjgTG0a5se2RXCp1yZ7IYh4r8/mNZbn95DmByAPdL9w7Kk6Kh/aRfjg/dc2P2E2YCBRvmU4HRn hidwt7CiOdlE284ua X-Received: by 2002:a1c:b741:: with SMTP id h62mr17331298wmf.85.1614088163363; Tue, 23 Feb 2021 05:49:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJzWyIcShiLHe07mw9HE/r5BInLl+NukEK8C2wh6/ekL9Dgw0dtDjxRuJKOsywf6vYjLteh5cg== X-Received: by 2002:a1c:b741:: with SMTP id h62mr17331273wmf.85.1614088163149; Tue, 23 Feb 2021 05:49:23 -0800 (PST) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id s84sm198526wme.11.2021.02.23.05.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 05:49:22 -0800 (PST) Date: Tue, 23 Feb 2021 14:49:20 +0100 From: Stefano Garzarella To: Arseny Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jorgen Hansen , Andra Paraschiv , Norbert Slusarek , Colin Ian King , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stsp2@yandex.ru, oxffffaa@gmail.com Subject: Re: [RFC PATCH v5 10/19] virtio/vsock: simplify credit update function API Message-ID: <20210223134920.nvecqujytdfcqnbt@steredhat> References: <20210218053347.1066159-1-arseny.krasnov@kaspersky.com> <20210218053926.1068053-1-arseny.krasnov@kaspersky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210218053926.1068053-1-arseny.krasnov@kaspersky.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 18, 2021 at 08:39:23AM +0300, Arseny Krasnov wrote: >'virtio_transport_send_credit_update()' has some extra args: >1) 'type' may be set in 'virtio_transport_send_pkt_info()' using type > of socket. >2) This function is static and 'hdr' arg was always NULL. > >Signed-off-by: Arseny Krasnov >--- > net/vmw_vsock/virtio_transport_common.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > >diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c >index 1c9d71ca5e8e..833104b71a1c 100644 >--- a/net/vmw_vsock/virtio_transport_common.c >+++ b/net/vmw_vsock/virtio_transport_common.c >@@ -271,13 +271,10 @@ void virtio_transport_put_credit(struct virtio_vsock_sock *vvs, u32 credit) > } > EXPORT_SYMBOL_GPL(virtio_transport_put_credit); > >-static int virtio_transport_send_credit_update(struct vsock_sock *vsk, >- int type, >- struct virtio_vsock_hdr *hdr) >+static int virtio_transport_send_credit_update(struct vsock_sock *vsk) > { > struct virtio_vsock_pkt_info info = { > .op = VIRTIO_VSOCK_OP_CREDIT_UPDATE, >- .type = type, > .vsk = vsk, > }; I don't know if it's better to remove type with the others changes in the previous patch, maybe it's more consistent. I mean only the removal of 'type' parameter, the 'hdr' parameter should be removed with this patch. > >@@ -385,11 +382,8 @@ virtio_transport_stream_do_dequeue(struct vsock_sock *vsk, > * messages, we set the limit to a high value. TODO: experiment > * with different values. > */ >- if (free_space < VIRTIO_VSOCK_MAX_PKT_BUF_SIZE) { >- virtio_transport_send_credit_update(vsk, >- >VIRTIO_VSOCK_TYPE_STREAM, >- NULL); >- } >+ if (free_space < VIRTIO_VSOCK_MAX_PKT_BUF_SIZE) >+ virtio_transport_send_credit_update(vsk); > > return total; > >@@ -498,8 +492,7 @@ void virtio_transport_notify_buffer_size(struct vsock_sock *vsk, u64 *val) > > vvs->buf_alloc = *val; > >- virtio_transport_send_credit_update(vsk, VIRTIO_VSOCK_TYPE_STREAM, >- NULL); >+ virtio_transport_send_credit_update(vsk); > } > EXPORT_SYMBOL_GPL(virtio_transport_notify_buffer_size); > >-- >2.25.1 >