Re: [PATCH] net: bridge: add a function that replays port and host-joined

kernel test robot
2021-02-24T02:02:51Z

[-- Attachment #1: Type: text/plain, Size: 3866 bytes --]

Hi Vladimir,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.11 next-20210223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/net-bridge-add-a-function-that-replays-port-and-host-joined/20210224-035325
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3b9cdafb5358eb9f3790de2f728f765fef100731
config: powerpc-randconfig-r003-20210223 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://github.com/0day-ci/linux/commit/ec816a5f014e0f0faacfe0462dcb1eeff54d8e50
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vladimir-Oltean/net-bridge-add-a-function-that-replays-port-and-host-joined/20210224-035325
git checkout ec816a5f014e0f0faacfe0462dcb1eeff54d8e50
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> net/dsa/slave.c:1959:47: error: use of undeclared identifier 'dsa_slave_switchdev_blocking_notifier'
err = br_mdb_replay(info->upper_dev, dev, &dsa_slave_switchdev_blocking_notifier);
^
1 error generated.

vim +/dsa_slave_switchdev_blocking_notifier +1959 net/dsa/slave.c

1947
1948 static int dsa_slave_changeupper(struct net_device *dev,
1949 struct netdev_notifier_changeupper_info *info)
1950 {
1951 struct dsa_port *dp = dsa_slave_to_port(dev);
1952 int err = NOTIFY_DONE;
1953
1954 if (netif_is_bridge_master(info->upper_dev)) {
1955 if (info->linking) {
1956 err = dsa_port_bridge_join(dp, info->upper_dev);
1957 if (!err)
1958 dsa_bridge_mtu_normalization(dp);
> 1959 err = br_mdb_replay(info->upper_dev, dev, &dsa_slave_switchdev_blocking_notifier);
1960 err = notifier_from_errno(err);
1961 } else {
1962 dsa_port_bridge_leave(dp, info->upper_dev);
1963 err = NOTIFY_OK;
1964 }
1965 } else if (netif_is_lag_master(info->upper_dev)) {
1966 if (info->linking) {
1967 err = dsa_port_lag_join(dp, info->upper_dev,
1968 info->upper_info);
1969 if (err == -EOPNOTSUPP) {
1970 NL_SET_ERR_MSG_MOD(info->info.extack,
1971 "Offloading not supported");
1972 err = 0;
1973 }
1974 err = notifier_from_errno(err);
1975 } else {
1976 dsa_port_lag_leave(dp, info->upper_dev);
1977 err = NOTIFY_OK;
1978 }
1979 } else if (is_hsr_master(info->upper_dev)) {
1980 if (info->linking) {
1981 err = dsa_port_hsr_join(dp, info->upper_dev);
1982 if (err == -EOPNOTSUPP) {
1983 NL_SET_ERR_MSG_MOD(info->info.extack,
1984 "Offloading not supported");
1985 err = 0;
1986 }
1987 err = notifier_from_errno(err);
1988 } else {
1989 dsa_port_hsr_leave(dp, info->upper_dev);
1990 err = NOTIFY_OK;
1991 }
1992 }
1993
1994 return err;
1995 }
1996

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31418 bytes --]