From: Vladimir Oltean <olteanv@gmail.com>
To: Ido Schimmel <idosch@idosch.org>
Cc: Nikolay Aleksandrov <nikolay@nvidia.com>,
Roopa Prabhu <roopa@nvidia.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org
Subject: Re: Timing of host-joined bridge multicast groups with switchdev
Date: Tue, 23 Feb 2021 22:07:06 +0200 [thread overview]
Message-ID: <20210223200706.wubjodat6dyn2bmi@skbuf> (raw)
In-Reply-To: <20210223194908.ne4a7abulirqfbs6@skbuf>
On Tue, Feb 23, 2021 at 09:49:08PM +0200, Vladimir Oltean wrote:
> > But I'm not sure how we replay it only for a single notifier block. I'm
> > not familiar with setups where you have more than one listener let alone
> > more than one that is interested in notifications from a specific
> > bridge, so maybe it is OK to just replay it for all the listeners. But I
> > would prefer to avoid it if we can.
>
> At least with a driver-initiated pull, this seems to work:
...
> I am just not sure why I need to emit the notification only once per
> ASIC. Currently, SWITCHDEV_OBJ_ID_HOST_MDB is emitted for all bridge
> ports, so the callers need to reference-count it anyway. As for the port
> mdb entries, I am filtering the entries towards just a single port when
> that joins. So I think this is okay.
Sorry, I'm a bit more slow today.
So there seems to be no easy way to get access to the notifier block
that the new port uses, instead we can only call the entire notifier
chain from the bridge layer. I guess I'll have to defer that problem
until enough drivers make use of the pull mechanism that it becomes
unbearable then.
next prev parent reply other threads:[~2021-02-23 20:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 17:37 Timing of host-joined bridge multicast groups with switchdev Vladimir Oltean
2021-02-23 17:56 ` Ido Schimmel
2021-02-23 18:02 ` Vladimir Oltean
2021-02-23 19:29 ` Ido Schimmel
2021-02-23 19:49 ` Vladimir Oltean
2021-02-23 20:07 ` Vladimir Oltean [this message]
2021-02-24 2:01 ` [PATCH] net: bridge: add a function that replays port and host-joined kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223200706.wubjodat6dyn2bmi@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).