From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 185DBC433DB for ; Tue, 23 Feb 2021 20:09:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E046864E22 for ; Tue, 23 Feb 2021 20:09:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234161AbhBWUI7 (ORCPT ); Tue, 23 Feb 2021 15:08:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234195AbhBWUHu (ORCPT ); Tue, 23 Feb 2021 15:07:50 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF337C06174A for ; Tue, 23 Feb 2021 12:07:09 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id jt13so36499751ejb.0 for ; Tue, 23 Feb 2021 12:07:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RBGCQP3sS45lWfuY4fvQFlAIxRom/+cG1QpxcL52oqU=; b=Vk1hNO0uUOHo8BBgph9fhMJ1NNRFSUEgKLDNgcLnLQhAMPJhLyEKiWca+PO8F+BXeX piCR7BXlb57d0VE+tR8aLaKIln7wARrUuUnw+TqwDeTVQgqVWt1dTdpd+h3ruMRgOsDq CHV2NDnGKntuHsmX69ZZFLxPtvNfaaojQ0bKzZ3aevMh162QOST4lUaB4KX8CZfpeEc2 2rRNF8yLFQn4BoNjYbp6imCYjeDL7h8s9MiK4EHH93/lfi+JSLqi0euZ/WCjGnpYW6ET h5rb+dgmpXXTCA+HY1kMxA5yqFZhLBxfT1G8vRPpY+V1sa4JFEejWUddT0aGPx0q6BAs jdOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RBGCQP3sS45lWfuY4fvQFlAIxRom/+cG1QpxcL52oqU=; b=Oc/ZAvUXWdy0LHiFImTLWm4JOHRW0WzF9/CkUgDKpS+lRMQ4R1rEDd/YEXYhrHC0fN CwLlL8s6H7LzacujXETYWi8qT9DAnIUhArqWr7HtjkfdOI3esXuMM2o6zVAEH60zwrTK z1p9mcjW6wT0anecbdrhTpqAcYr9QZMKkrcMvFVPPom35+q0eFhPxAFGh98m+VHR0GvF QKOdrjpQg3qF32nxHB1uwT8KrwxlP46wHrn4+roJYoB78/JsX8KeKE21PY7G8Nlp/Lf3 3BA0Drz8C53d4PI1fceULaErbVObln+GGJdJqwlZXnF8bDnPjVORuZYc6fIB/y/kDhVQ nimQ== X-Gm-Message-State: AOAM531Pbo2WD0UFi4YYIQqIbSjimqWdWfkvQXXtMs4UEb32nkAZtHRN w7WD7KseeYqgk1rRCxIkTuo= X-Google-Smtp-Source: ABdhPJwLO1hkzUzIneI2KCgdscXpFppOh0AFSqiFyK0cEy4SgrEQjMcBgHWXFYqGWMR4VMHN1HdTTg== X-Received: by 2002:a17:907:94d4:: with SMTP id dn20mr28004939ejc.397.1614110828772; Tue, 23 Feb 2021 12:07:08 -0800 (PST) Received: from skbuf ([188.25.217.13]) by smtp.gmail.com with ESMTPSA id j24sm1487989edy.3.2021.02.23.12.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 12:07:08 -0800 (PST) Date: Tue, 23 Feb 2021 22:07:06 +0200 From: Vladimir Oltean To: Ido Schimmel Cc: Nikolay Aleksandrov , Roopa Prabhu , Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org Subject: Re: Timing of host-joined bridge multicast groups with switchdev Message-ID: <20210223200706.wubjodat6dyn2bmi@skbuf> References: <20210223173753.vrlxhnj5rtvd6i6g@skbuf> <20210223180236.e2ggiuxhr5aaayx5@skbuf> <20210223194908.ne4a7abulirqfbs6@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210223194908.ne4a7abulirqfbs6@skbuf> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 23, 2021 at 09:49:08PM +0200, Vladimir Oltean wrote: > > But I'm not sure how we replay it only for a single notifier block. I'm > > not familiar with setups where you have more than one listener let alone > > more than one that is interested in notifications from a specific > > bridge, so maybe it is OK to just replay it for all the listeners. But I > > would prefer to avoid it if we can. > > At least with a driver-initiated pull, this seems to work: ... > I am just not sure why I need to emit the notification only once per > ASIC. Currently, SWITCHDEV_OBJ_ID_HOST_MDB is emitted for all bridge > ports, so the callers need to reference-count it anyway. As for the port > mdb entries, I am filtering the entries towards just a single port when > that joins. So I think this is okay. Sorry, I'm a bit more slow today. So there seems to be no easy way to get access to the notifier block that the new port uses, instead we can only call the entire notifier chain from the bridge layer. I guess I'll have to defer that problem until enough drivers make use of the pull mechanism that it becomes unbearable then.