From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88135C433DB for ; Wed, 24 Feb 2021 08:25:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 496EB64ED3 for ; Wed, 24 Feb 2021 08:25:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232394AbhBXIY7 (ORCPT ); Wed, 24 Feb 2021 03:24:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51910 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231788AbhBXIYx (ORCPT ); Wed, 24 Feb 2021 03:24:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614155006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1JbGPMGc3zR5mJ9ryS3aC3fSGYocZkjlOuNb6WBZZ3I=; b=KSGq+666prtCURPW2NWMu9TT5irzC6T/ytkR3X0+dQZAp65bfqyRkCkL0+ZZklzaFoRmdC a4kx0Wy28vYagEajpFldjPPd9MCwmrRxbbpRVk6Jt/rA1CFq+8aiW9jaD31ozJgEG8Xtf2 hUvTV3bR9mLtlMEP+vzC1iqSwXl1u9A= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-lkRpBI9oO7WC53EnO8ckEA-1; Wed, 24 Feb 2021 03:23:24 -0500 X-MC-Unique: lkRpBI9oO7WC53EnO8ckEA-1 Received: by mail-wr1-f72.google.com with SMTP id d10so696016wrq.17 for ; Wed, 24 Feb 2021 00:23:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1JbGPMGc3zR5mJ9ryS3aC3fSGYocZkjlOuNb6WBZZ3I=; b=ql15xVZXOULKWzGtYp+Yb9wxdUaGRI7hiDAZ8l2/pqawNOOIkm4FYw0SN9gZ+Bom6K NqgNSt6slbkrXMkV/LxDAf5MmhEnQGB1Z9Aw9IQTHM5RDPhSbrM5ROQfjmY7EfHmH27l gf0teF6Ok6zdPu/OJ23/8UxXJJ6cz6dnRyY/GbJSMHU4HQA/RgiKQGO+QXcdItT5SOe2 H5ydzfj9WBcKuBopukF1z0dmk6Bhw+DRss6q8OzmWQiKXbRXOaAqnFPi1g4bgPVfdZ5Y eqrPcHDHH1jWludJQax/3mZvMsRr1GLog+0ihjWamHT4zUPXRlP5ly5LTlBrJG1TYBkM i8tQ== X-Gm-Message-State: AOAM530BnFXdrckjOJ0hvl7IlSHhfHNre2zDteYZy6jQVUXcCiC9TgrH avjIS8OGMmyU1gEl8rY9yr1pKBHZna0HLiaO26gYURZ+B4nYN0lgs9AiaDA68/yLedJDdpW5UIc KaX9It0FhE+rNYmIo X-Received: by 2002:a7b:cb81:: with SMTP id m1mr2574146wmi.117.1614155003182; Wed, 24 Feb 2021 00:23:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwr2zof1ZDDqJMUOF+ohaSrHn1X03ArrZY1vRa0Mt+0/xGnqxU7+pV+gRMZdhng3Liw6tsb4Q== X-Received: by 2002:a7b:cb81:: with SMTP id m1mr2574122wmi.117.1614155002974; Wed, 24 Feb 2021 00:23:22 -0800 (PST) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id a1sm2056803wrx.95.2021.02.24.00.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 00:23:22 -0800 (PST) Date: Wed, 24 Feb 2021 09:23:19 +0100 From: Stefano Garzarella To: Arseny Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jorgen Hansen , Andra Paraschiv , Norbert Slusarek , Colin Ian King , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stsp2@yandex.ru" , "oxffffaa@gmail.com" Subject: Re: [RFC PATCH v5 00/19] virtio/vsock: introduce SOCK_SEQPACKET support Message-ID: <20210224082319.yrmqr6zs7emvghw3@steredhat> References: <20210218053347.1066159-1-arseny.krasnov@kaspersky.com> <20210222142311.gekdd7gsm33wglos@steredhat> <20210223145016.ddavx6fihq4akdim@steredhat> <7a280168-cb54-ae26-4697-c797f6b04708@kaspersky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <7a280168-cb54-ae26-4697-c797f6b04708@kaspersky.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 24, 2021 at 07:29:25AM +0300, Arseny Krasnov wrote: > >On 23.02.2021 17:50, Stefano Garzarella wrote: >> On Mon, Feb 22, 2021 at 03:23:11PM +0100, Stefano Garzarella wrote: >>> Hi Arseny, >>> >>> On Thu, Feb 18, 2021 at 08:33:44AM +0300, Arseny Krasnov wrote: >>>> This patchset impelements support of SOCK_SEQPACKET for virtio >>>> transport. >>>> As SOCK_SEQPACKET guarantees to save record boundaries, so to >>>> do it, two new packet operations were added: first for start of record >>>> and second to mark end of record(SEQ_BEGIN and SEQ_END later). Also, >>>> both operations carries metadata - to maintain boundaries and payload >>>> integrity. Metadata is introduced by adding special header with two >>>> fields - message count and message length: >>>> >>>> struct virtio_vsock_seq_hdr { >>>> __le32 msg_cnt; >>>> __le32 msg_len; >>>> } __attribute__((packed)); >>>> >>>> This header is transmitted as payload of SEQ_BEGIN and SEQ_END >>>> packets(buffer of second virtio descriptor in chain) in the same way as >>>> data transmitted in RW packets. Payload was chosen as buffer for this >>>> header to avoid touching first virtio buffer which carries header of >>>> packet, because someone could check that size of this buffer is equal >>>> to size of packet header. To send record, packet with start marker is >>>> sent first(it's header contains length of record and counter), then >>>> counter is incremented and all data is sent as usual 'RW' packets and >>>> finally SEQ_END is sent(it also carries counter of message, which is >>>> counter of SEQ_BEGIN + 1), also after sedning SEQ_END counter is >>>> incremented again. On receiver's side, length of record is known from >>>> packet with start record marker. To check that no packets were dropped >>>> by transport, counters of two sequential SEQ_BEGIN and SEQ_END are >>>> checked(counter of SEQ_END must be bigger that counter of SEQ_BEGIN by >>>> 1) and length of data between two markers is compared to length in >>>> SEQ_BEGIN header. >>>> Now as packets of one socket are not reordered neither on >>>> vsock nor on vhost transport layers, such markers allows to restore >>>> original record on receiver's side. If user's buffer is smaller that >>>> record length, when all out of size data is dropped. >>>> Maximum length of datagram is not limited as in stream socket, >>>> because same credit logic is used. Difference with stream socket is >>>> that user is not woken up until whole record is received or error >>>> occurred. Implementation also supports 'MSG_EOR' and 'MSG_TRUNC' flags. >>>> Tests also implemented. >>> I reviewed the first part (af_vsock.c changes), tomorrow I'll review >>> the rest. That part looks great to me, only found a few minor issues. >> I revieiwed the rest of it as well, left a few minor comments, but I >> think we're well on track. >> >> I'll take a better look at the specification patch tomorrow. >Great, Thank You >> >> Thanks, >> Stefano >> >>> In the meantime, however, I'm getting a doubt, especially with regard >>> to other transports besides virtio. >>> >>> Should we hide the begin/end marker sending in the transport? >>> >>> I mean, should the transport just provide a seqpacket_enqueue() >>> callbacl? >>> Inside it then the transport will send the markers. This is because >>> some transports might not need to send markers. >>> >>> But thinking about it more, they could actually implement stubs for >>> that calls, if they don't need to send markers. >>> >>> So I think for now it's fine since it allows us to reuse a lot of >>> code, unless someone has some objection. > >I thought about that, I'll try to implement it in next version. Let's see... If you want to discuss it first, write down the idea you want to implement, I wouldn't want to make you do unnecessary work. :-) Cheers, Stefano