From: Vladimir Oltean <olteanv@gmail.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Michael Walle <michael@walle.cc>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandru Marginean <alexandru.marginean@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net 6/6] net: enetc: force the RGMII speed and duplex instead of operating in inband mode
Date: Thu, 25 Feb 2021 14:13:14 +0200 [thread overview]
Message-ID: <20210225121314.c3lphdy7fhoygbmi@skbuf> (raw)
In-Reply-To: <20210225112942.GT1463@shell.armlinux.org.uk>
On Thu, Feb 25, 2021 at 11:29:42AM +0000, Russell King - ARM Linux admin wrote:
> On Thu, Feb 25, 2021 at 01:23:57PM +0200, Vladimir Oltean wrote:
> > static void enetc_pl_mac_link_up(struct phylink_config *config,
> > struct phy_device *phy, unsigned int mode,
> > phy_interface_t interface, int speed,
> > @@ -945,6 +981,10 @@ static void enetc_pl_mac_link_up(struct phylink_config *config,
> > enetc_sched_speed_set(priv, speed);
> >
> > enetc_mac_enable(&pf->si->hw, true);
> > +
> > + if (!phylink_autoneg_inband(mode) &&
> > + phy_interface_mode_is_rgmii(interface))
> > + enetc_force_rgmii_mac(&pf->si->hw, speed, duplex);
>
> Does it matter that you're forcing the RGMII setup after having enabled
> the MAC?
Thanks, this is a good point. I had tested only at gigabit on the
LS1028A-QDS, but at 10/100 things seem to be broken if I update the
speed with the MAC being enabled. I'll send a v2 with this change and
also with a build failure fix for patch 4/6.
prev parent reply other threads:[~2021-02-25 12:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 11:23 [PATCH net 0/6] Fixes for NXP ENETC driver Vladimir Oltean
2021-02-25 11:23 ` [PATCH net 1/6] net: enetc: don't overwrite the RSS indirection table when initializing Vladimir Oltean
2021-02-25 11:23 ` [PATCH net 2/6] net: enetc: initialize RFS/RSS memories for unused ports too Vladimir Oltean
2021-02-25 11:23 ` [PATCH net 3/6] net: enetc: take the MDIO lock only once per NAPI poll cycle Vladimir Oltean
2021-02-25 11:23 ` [PATCH net 4/6] net: enetc: fix incorrect TPID when receiving 802.1ad tagged packets Vladimir Oltean
2021-02-25 11:23 ` [PATCH net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode Vladimir Oltean
2021-02-25 11:23 ` [PATCH net 6/6] net: enetc: force the RGMII speed and duplex instead of operating in inband mode Vladimir Oltean
2021-02-25 11:29 ` Russell King - ARM Linux admin
2021-02-25 12:13 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225121314.c3lphdy7fhoygbmi@skbuf \
--to=olteanv@gmail.com \
--cc=alexandru.marginean@nxp.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox