From: Ioana Ciornei <ioana.ciornei@nxp.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"brouer@redhat.com" <brouer@redhat.com>,
"toke@redhat.com" <toke@redhat.com>,
"freysteinn.alfredsson@kau.se" <freysteinn.alfredsson@kau.se>,
"lorenzo.bianconi@redhat.com" <lorenzo.bianconi@redhat.com>,
"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"mst@redhat.com" <mst@redhat.com>,
"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
"mw@semihalf.com" <mw@semihalf.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"ilias.apalodimas@linaro.org" <ilias.apalodimas@linaro.org>,
"netanel@amazon.com" <netanel@amazon.com>,
"akiyano@amazon.com" <akiyano@amazon.com>,
"michael.chan@broadcom.com" <michael.chan@broadcom.com>,
Madalin Bucur <madalin.bucur@nxp.com>,
"jesse.brandeburg@intel.com" <jesse.brandeburg@intel.com>,
"anthony.l.nguyen@intel.com" <anthony.l.nguyen@intel.com>,
"saeedm@nvidia.com" <saeedm@nvidia.com>,
"grygorii.strashko@ti.com" <grygorii.strashko@ti.com>,
"ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>
Subject: Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT
Date: Mon, 1 Mar 2021 11:59:54 +0000 [thread overview]
Message-ID: <20210301115953.dufjdjnbmmwooxaf@skbuf> (raw)
In-Reply-To: <d0c326f95b2d0325f63e4040c1530bf6d09dc4d4.1614422144.git.lorenzo@kernel.org>
On Sat, Feb 27, 2021 at 12:04:13PM +0100, Lorenzo Bianconi wrote:
> We want to change the current ndo_xdp_xmit drop semantics because
> it will allow us to implement better queue overflow handling.
> This is working towards the larger goal of a XDP TX queue-hook.
> Move XDP_REDIRECT error path handling from each XDP ethernet driver to
> devmap code. According to the new APIs, the driver running the
> ndo_xdp_xmit pointer, will break tx loop whenever the hw reports a tx
> error and it will just return to devmap caller the number of successfully
> transmitted frames. It will be devmap responsability to free dropped
> frames.
> Move each XDP ndo_xdp_xmit capable driver to the new APIs:
> - veth
> - virtio-net
> - mvneta
> - mvpp2
> - socionext
> - amazon ena
> - bnxt
> - freescale (dpaa2, dpaa)
> - xen-frontend
> - qede
> - ice
> - igb
> - ixgbe
> - i40e
> - mlx5
> - ti (cpsw, cpsw-new)
> - tun
> - sfc
>
> Acked-by: Edward Cree <ecree.xilinx@gmail.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com> # for the dpaa2-eth
next prev parent reply other threads:[~2021-03-01 12:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 11:04 [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT Lorenzo Bianconi
2021-02-28 12:15 ` Shay Agroskin
2021-02-28 22:27 ` Lorenzo Bianconi
2021-03-01 7:48 ` Jesper Dangaard Brouer
2021-03-01 11:23 ` Shay Agroskin
2021-03-01 20:18 ` Jesper Dangaard Brouer
2021-03-02 15:28 ` Lorenzo Bianconi
2021-03-03 11:29 ` Shay Agroskin
2021-03-01 11:59 ` Ioana Ciornei [this message]
2021-03-01 12:26 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301115953.dufjdjnbmmwooxaf@skbuf \
--to=ioana.ciornei@nxp.com \
--cc=akiyano@amazon.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=freysteinn.alfredsson@kau.se \
--cc=grygorii.strashko@ti.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jasowang@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=michael.chan@broadcom.com \
--cc=mst@redhat.com \
--cc=mw@semihalf.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox