From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Mark Bloch <mbloch@nvidia.com>,
"Adit Ranadive" <aditr@vmware.com>,
Ariel Elior <aelior@marvell.com>,
"Bart Van Assche" <bvanassche@acm.org>,
Bernard Metzler <bmt@zurich.ibm.com>,
"Christian Benvenuti" <benve@cisco.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Devesh Sharma <devesh.sharma@broadcom.com>,
Faisal Latif <faisal.latif@intel.com>,
"Gal Pressman" <galpress@amazon.com>,
Jakub Kicinski <kuba@kernel.org>, Lijun Ou <oulijun@huawei.com>,
<linux-rdma@vger.kernel.org>,
Michal Kalderon <mkalderon@marvell.com>,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
Nelson Escobar <neescoba@cisco.com>, <netdev@vger.kernel.org>,
Potnuri Bharat Teja <bharat@chelsio.com>,
"Saeed Mahameed" <saeedm@nvidia.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
<target-devel@vger.kernel.org>,
"VMware PV-Drivers" <pv-drivers@vmware.com>,
Weihang Li <liweihang@huawei.com>,
"Wei Hu(Xavier)" <huwei87@hisilicon.com>,
Yishai Hadas <yishaih@nvidia.com>,
"Zhu Yanjun" <zyjzyj2000@gmail.com>
Subject: Re: [PATCH rdma-next] RDMA: Support more than 255 rdma ports
Date: Mon, 1 Mar 2021 08:48:34 -0400 [thread overview]
Message-ID: <20210301124834.GE4247@nvidia.com> (raw)
In-Reply-To: <20210301070420.439400-1-leon@kernel.org>
On Mon, Mar 01, 2021 at 09:04:20AM +0200, Leon Romanovsky wrote:
> @@ -884,7 +884,7 @@ static void gid_table_reserve_default(struct ib_device *ib_dev, u8 port,
>
> static void gid_table_release_one(struct ib_device *ib_dev)
> {
> - unsigned int p;
> + u32 p;
>
> rdma_for_each_port (ib_dev, p) {
> release_gid_table(ib_dev, ib_dev->port_data[p].cache.gid);
> @@ -895,7 +895,7 @@ static void gid_table_release_one(struct ib_device *ib_dev)
> static int _gid_table_setup_one(struct ib_device *ib_dev)
> {
> struct ib_gid_table *table;
> - unsigned int rdma_port;
> + u32 rdma_port;
>
> rdma_for_each_port (ib_dev, rdma_port) {
Why are we changing this? 'unsigned int' is the right type for port
numbers
Jason
next prev parent reply other threads:[~2021-03-01 12:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 7:04 [PATCH rdma-next] RDMA: Support more than 255 rdma ports Leon Romanovsky
2021-03-01 12:48 ` Jason Gunthorpe [this message]
2021-03-01 14:44 ` Leon Romanovsky
2021-03-25 7:49 ` Leon Romanovsky
2021-03-26 13:19 ` Jason Gunthorpe
2021-03-29 13:36 ` Saleem, Shiraz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301124834.GE4247@nvidia.com \
--to=jgg@nvidia.com \
--cc=aditr@vmware.com \
--cc=aelior@marvell.com \
--cc=benve@cisco.com \
--cc=bharat@chelsio.com \
--cc=bmt@zurich.ibm.com \
--cc=bvanassche@acm.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=galpress@amazon.com \
--cc=huwei87@hisilicon.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=liweihang@huawei.com \
--cc=mbloch@nvidia.com \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=mkalderon@marvell.com \
--cc=nareshkumar.pbs@broadcom.com \
--cc=neescoba@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=oulijun@huawei.com \
--cc=pv-drivers@vmware.com \
--cc=saeedm@nvidia.com \
--cc=selvin.xavier@broadcom.com \
--cc=shiraz.saleem@intel.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=target-devel@vger.kernel.org \
--cc=yishaih@nvidia.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).