Re: [PATCH net] net: dsa: tag_rtl4_a: fix egress tags

Vladimir Oltean
2021-03-01T14:02:31Z

On Mon, Mar 01, 2021 at 02:58:59PM +0100, Linus Walleij wrote:
> On Sun, Feb 28, 2021 at 6:08 PM DENG Qingfang <dqfext@gmail.com> wrote:
>
> > Commit 86dd9868b878 has several issues, but was accepted too soon
> > before anyone could take a look.
> >
> > - Double free. dsa_slave_xmit() will free the skb if the xmit function
> > returns NULL, but the skb is already freed by eth_skb_pad(). Use
> > __skb_put_padto() to avoid that.
> > - Unnecessary allocation. It has been done by DSA core since commit
> > a3b0b6479700.
> > - A u16 pointer points to skb data. It should be __be16 for network
> > byte order.
> > - Typo in comments. "numer" -> "number".
> >
> > Fixes: 86dd9868b878 ("net: dsa: tag_rtl4_a: Support also egress tags")
> > Signed-off-by: DENG Qingfang <dqfext@gmail.com>
>
> Ooops I send patches before properly going through the mailbox.
> Oh well things like that happen.
>
> David: ignore my patches to the same tagger and apply this instead!
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Yours,
> Linus Walleij

Last time I checked, performance/timing sensitive code is impacted by
netdev_dbg calls even if dynamic debugging isn't turned on. However,
neither your patches nor Qingfang's have removed that netdev_dbg line.
Is there any good reason to keep it?