Re: [PATCH net] net: dsa: tag_rtl4_a: fix egress tags

Florian Fainelli
2021-02-28T17:55:12Z

On 2/28/2021 9:08 AM, DENG Qingfang wrote:
> Commit 86dd9868b878 has several issues, but was accepted too soon
> before anyone could take a look.
>
> - Double free. dsa_slave_xmit() will free the skb if the xmit function
> returns NULL, but the skb is already freed by eth_skb_pad(). Use
> __skb_put_padto() to avoid that.
> - Unnecessary allocation. It has been done by DSA core since commit
> a3b0b6479700.
> - A u16 pointer points to skb data. It should be __be16 for network
> byte order.
> - Typo in comments. "numer" -> "number".
>
> Fixes: 86dd9868b878 ("net: dsa: tag_rtl4_a: Support also egress tags")
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian