From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0410EC43142 for ; Wed, 3 Mar 2021 04:10:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC16764E75 for ; Wed, 3 Mar 2021 04:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352689AbhCCEAr (ORCPT ); Tue, 2 Mar 2021 23:00:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:54010 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380382AbhCBL0g (ORCPT ); Tue, 2 Mar 2021 06:26:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614684265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1BhNztqEgWGMx7kPW5f0CLvD2WsnR/6LZwBjGCJ0xrE=; b=Bc7bbDxKvISIhKpZ3k5gBH5Z9izdzi8Qk48G9DwZTo6B5JTwj4Q/QkVl95va3I9qMsutx2 xQLlmWOYBKkZoAl74sA9ZgDLFnsu9xpg2Twzczg1X0ha1WTBdmJj0v0LukJi7Up9xizTUk r2obmSnJCp1515SbkuQ6IwqoUgBarZE= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-250-RImxKS3POMGWS12n_lDEsA-1; Tue, 02 Mar 2021 06:24:24 -0500 X-MC-Unique: RImxKS3POMGWS12n_lDEsA-1 Received: by mail-ej1-f70.google.com with SMTP id v10so8318733ejh.15 for ; Tue, 02 Mar 2021 03:24:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=1BhNztqEgWGMx7kPW5f0CLvD2WsnR/6LZwBjGCJ0xrE=; b=qut7RoNVes3RW5uNbIU68LT1BVwR95Rq3XGB7OkTkMEJ/BjjfRWDEbQ8Eypaa7Vs4y /vsvJ1B/nBl0rFYXyUstmf+ihMENPrLVdiGH1/DCWPKiOnOg4iAEzQwt3aC3UgiCjeV1 2zxwAuRhbats6rhC/w1CKx5qoVuj/HcfstByyxp3Gf9YjxZRpiV7v0y/jLCdvzcGeG7s 5NtBIoBbJnQY4yqSfJOydnULhrxutTfTFwaqnVZ5gTUCwnqo6D9B1ttYBxfqfxe9pjdr ou+nI1rwa7jbi7v7Esgs7MS1X0+ZEoZ8tS/2niuTMY39KLgPsqb7lLod7tCN4/lFCygx pDFQ== X-Gm-Message-State: AOAM531+wU2HQG0H5DHcL4KhIjx9TD28SuJB/HrCS/C4WrLLH2BSq4J9 0KpJMDnT+tjZMs3GnVJL6/DVjmVC3j9RGSmk8ZhqVt212zbZ4SRRDIMxq5S2gSFkbedURBAqP/M fOdFlmhKjnxqSQHPe X-Received: by 2002:a17:906:f296:: with SMTP id gu22mr19228814ejb.20.1614684263044; Tue, 02 Mar 2021 03:24:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJzGGNSokqgK/5RqqfSY3ERKl9lVWR62FSA4uJr14s6tOqkDbPKgW29y+nDnUA6mto+6bIvZew== X-Received: by 2002:a17:906:f296:: with SMTP id gu22mr19228806ejb.20.1614684262901; Tue, 02 Mar 2021 03:24:22 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id h2sm15994879ejk.32.2021.03.02.03.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 03:24:22 -0800 (PST) Date: Tue, 2 Mar 2021 06:24:19 -0500 From: "Michael S. Tsirkin" To: Eli Cohen Cc: Jason Wang , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH] vdpa/mlx5: Fix wrong use of bit numbers Message-ID: <20210302062405-mutt-send-email-mst@kernel.org> References: <20210301062817.39331-1-elic@nvidia.com> <959916f2-5fc9-bdb4-31ca-632fe0d98979@redhat.com> <20210301103214-mutt-send-email-mst@kernel.org> <20210302052306.GA227464@mtl-vdi-166.wap.labs.mlnx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210302052306.GA227464@mtl-vdi-166.wap.labs.mlnx> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 02, 2021 at 07:23:06AM +0200, Eli Cohen wrote: > On Mon, Mar 01, 2021 at 10:33:14AM -0500, Michael S. Tsirkin wrote: > > On Mon, Mar 01, 2021 at 03:52:45PM +0800, Jason Wang wrote: > > > > > > On 2021/3/1 2:28 下午, Eli Cohen wrote: > > > > VIRTIO_F_VERSION_1 is a bit number. Use BIT_ULL() with mask > > > > conditionals. > > > > > > > > Also, in mlx5_vdpa_is_little_endian() use BIT_ULL for consistency with > > > > the rest of the code. > > > > > > > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") > > > > Signed-off-by: Eli Cohen > > > > > > > > > Acked-by: Jason Wang > > > > And CC stable I guess? > > Is this a question or a request? :-) A question. net patches are cc'd by net maintainer. > > > > > > > > > --- > > > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > index dc7031132fff..7d21b857a94a 100644 > > > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > @@ -821,7 +821,7 @@ static int create_virtqueue(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtque > > > > MLX5_SET(virtio_q, vq_ctx, event_qpn_or_msix, mvq->fwqp.mqp.qpn); > > > > MLX5_SET(virtio_q, vq_ctx, queue_size, mvq->num_ent); > > > > MLX5_SET(virtio_q, vq_ctx, virtio_version_1_0, > > > > - !!(ndev->mvdev.actual_features & VIRTIO_F_VERSION_1)); > > > > + !!(ndev->mvdev.actual_features & BIT_ULL(VIRTIO_F_VERSION_1))); > > > > MLX5_SET64(virtio_q, vq_ctx, desc_addr, mvq->desc_addr); > > > > MLX5_SET64(virtio_q, vq_ctx, used_addr, mvq->device_addr); > > > > MLX5_SET64(virtio_q, vq_ctx, available_addr, mvq->driver_addr); > > > > @@ -1578,7 +1578,7 @@ static void teardown_virtqueues(struct mlx5_vdpa_net *ndev) > > > > static inline bool mlx5_vdpa_is_little_endian(struct mlx5_vdpa_dev *mvdev) > > > > { > > > > return virtio_legacy_is_little_endian() || > > > > - (mvdev->actual_features & (1ULL << VIRTIO_F_VERSION_1)); > > > > + (mvdev->actual_features & BIT_ULL(VIRTIO_F_VERSION_1)); > > > > } > > > > static __virtio16 cpu_to_mlx5vdpa16(struct mlx5_vdpa_dev *mvdev, u16 val) > >