From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Ivan Bornyakov <i.bornyakov@metrotek.ru>
Cc: netdev@vger.kernel.org, system@metrotek.ru, andrew@lunn.ch,
hkallweit1@gmail.com, davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: phy: add Marvell 88X2222 transceiver support
Date: Wed, 3 Mar 2021 11:36:55 +0000 [thread overview]
Message-ID: <20210303113655.GA1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210303105756.sdeiwg7hn3p4rtq4@dhcp-179.ddg>
Hi,
Mostly great, but just a couple more points.
On Wed, Mar 03, 2021 at 01:57:57PM +0300, Ivan Bornyakov wrote:
> + adv = 0;
> +
> + if (linkmode_test_bit(ETHTOOL_LINK_MODE_1000baseX_Full_BIT,
> + priv->supported))
> + adv |= ADVERTISE_1000XFULL;
> +
> + if (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
> + priv->supported))
> + adv |= ADVERTISE_1000XPAUSE;
> +
> + if (linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
> + priv->supported))
> + adv |= ADVERTISE_1000XPSE_ASYM;
You could use the helper:
adv = linkmode_adv_to_mii_adv_x(priv->supported,
ETHTOOL_LINK_MODE_1000baseX_Full_BIT);
instead here. It's also a bit weird to set the advertisement based off
a "supported" mask.
> + linkmode_set_bit(ETHTOOL_LINK_MODE_10000baseKR_Full_BIT, supported);
Does the PHY support backplane links?
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-03-04 0:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 19:22 [PATCH] net: phy: add Marvell 88X2222 transceiver support Ivan Bornyakov
2021-02-01 22:56 ` Andrew Lunn
2021-02-02 15:32 ` Ivan Bornyakov
2021-02-02 16:48 ` Russell King - ARM Linux admin
2021-02-02 20:45 ` Ivan Bornyakov
2021-02-20 9:46 ` [PATCH v2] " Ivan Bornyakov
2021-02-20 11:53 ` Russell King - ARM Linux admin
2021-02-20 15:51 ` Ivan Bornyakov
2021-02-20 16:30 ` Andrew Lunn
2021-02-20 16:27 ` Andrew Lunn
2021-03-03 10:57 ` [PATCH v3] " Ivan Bornyakov
2021-03-03 11:36 ` Russell King - ARM Linux admin [this message]
2021-03-03 15:27 ` Ivan Bornyakov
2021-03-03 16:02 ` [PATCH v4] " Ivan Bornyakov
2021-03-10 9:33 ` Ivan Bornyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303113655.GA1463@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=i.bornyakov@metrotek.ru \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=system@metrotek.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).